Community
Participate
Working Groups
(I can't find an existing bug on this) One of the items on the 9.0 Planning [1] is removal of CDI Debug. This is the bugzilla to track that. [1] https://wiki.eclipse.org/CDT/planning/9.0
New Gerrit change created: https://git.eclipse.org/r/63282
Some methods and classes got marked for removal in https://git.eclipse.org/r/#/c/63288/
Very cool! Thanks, Jonah. I'll take a look once I get a few other things done. Might not happen until after the holidays.
(In reply to Doug Schaefer from comment #3) > Very cool! Thanks, Jonah. I'll take a look once I get a few other things > done. Might not happen until after the holidays. No problem. I know you are busy, just hoping I can help a little here. All of this has been motivated by exploring the code as a result of my work on Bug 472765. I'll keep at it, have a review when you get a chance. Happy holidays!
You've been a huge help! Much appreciated. Happy holidays!
Gerrit change https://git.eclipse.org/r/63282 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=ff7f25b94d9d4978be6ebe32cc2b39d924de6062
(In reply to Eclipse Genie from comment #6) > Gerrit change https://git.eclipse.org/r/63282 was merged to [master]. > Commit: > http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/ > ?id=ff7f25b94d9d4978be6ebe32cc2b39d924de6062 Now that the "big" one has gone in there are a few outstanding issues: - Remove most of the public interfaces of CDI (org.eclipse.cdt.debug.core.model) are still in place, many of them are part of DSF so its not as simple as delete the whole package - Activities need to be updated/reviewed - The plugin.xmls have not been reviewed much, only so far to remove dependencies on classes that were removed. - LocalCDILaunchDelegate should be removed, for now I have only removed all the debug parts of it, but most of what is left delegates to LocalRunLaunchDelegate - Cleanup/Rename CDI* classes used by DSF
New Gerrit change created: https://git.eclipse.org/r/68011
New Gerrit change created: https://git.eclipse.org/r/68010
Gerrit change https://git.eclipse.org/r/68011 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=6a61206d08f25467891b42285948a0076b64bedf
Commit http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=28b1830acf942216ae99d4d167b6c3b2133aaec6 added some deprecations that can be simply removed if I can get to them this week. Lines are marked "@deprecated Only used by CDI, scheduled for removal as part of Bug 484900"
New Gerrit change created: https://git.eclipse.org/r/68598
Gerrit change https://git.eclipse.org/r/68598 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=a29e37cffcc13fa23309f5bbbd76da4a17aacc85
New Gerrit change created: https://git.eclipse.org/r/68785
New Gerrit change created: https://git.eclipse.org/r/68788
New Gerrit change created: https://git.eclipse.org/r/68795
New Gerrit change created: https://git.eclipse.org/r/68799
Gerrit change https://git.eclipse.org/r/68010 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=6fc6c3c67169d6f5bb6ab1a8336cb06a9320cad0
Gerrit change https://git.eclipse.org/r/68785 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=58081e64ef1370f65614c269bd29bee2ad687ef9
Gerrit change https://git.eclipse.org/r/68795 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=3b442e1f37e470a0235325aa64b32547ed23a7d0
Gerrit change https://git.eclipse.org/r/68799 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=b34301fbb04484c17335ab6c33457484b0ef6517
Gerrit change https://git.eclipse.org/r/68788 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=3fb0862d7c7c9797720bddeed55cc0a143673705
New Gerrit change created: https://git.eclipse.org/r/68827
(In reply to Eclipse Genie from comment #23) > New Gerrit change created: https://git.eclipse.org/r/68827 I've abandoned this one.
(In reply to Jonah Graham from comment #7) > Now that the "big" one has gone in there are a few outstanding issues: > > - Remove most of the public interfaces of CDI > (org.eclipse.cdt.debug.core.model) are still in place, many of them are > part of DSF so its not as simple as delete the whole package > > - Activities need to be updated/reviewed > > - The plugin.xmls have not been reviewed much, only so far to remove > dependencies on classes that were removed. > > - LocalCDILaunchDelegate should be removed, for now I have only removed > all the debug parts of it, but most of what is left delegates to > LocalRunLaunchDelegate This has been done. > - Cleanup/Rename CDI* classes used by DSF At EclipeCon2016 we agreed to keep old classes but make then stubs that point to a properly named set of classes.
New Gerrit change created: https://git.eclipse.org/r/86411
Gerrit change https://git.eclipse.org/r/86411 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=e7ccfabb32ac49c7f5c1d0a6181d91aead2b9dd1
It seems the main job has been done and released, shouldn't we marked this one as fixed now ?
(In reply to Alvaro Sanchez-Leon from comment #28) > It seems the main job has been done and released, > > shouldn't we marked this one as fixed now ? Yes! Note I put "Fixed version" as 9.0. Everything except the recent documentation cleanup (https://git.eclipse.org/r/86411) was in 9.0, the documentation one is in 9.3 I created bug 508992 to cover any of the remnants.
(In reply to Jonah Graham from comment #29) > Note I put "Fixed version" as 9.0. Everything except the recent > documentation cleanup (https://git.eclipse.org/r/86411) was in 9.0, the > documentation one is in 9.3 > > I created bug 508992 to cover any of the remnants. Great ! Thanks Jonah !
Hi Jonah, does any wiki page exist, that is dedicated to migrating code that used the removed APIs? I'm guessing there was a paradigm switch, I would like to read about it; we are in the process of updating an older product to CDT 9.x, we have some code that uses the (apparently) old CDT debug framework. Best regards and thanks, Simeon
(In reply to Simeon Andreev from comment #31) > Hi Jonah, > > does any wiki page exist, that is dedicated to migrating code that used the > removed APIs? > > I'm guessing there was a paradigm switch, I would like to read about it; we > are in the process of updating an older product to CDT 9.x, we have some > code that uses the (apparently) old CDT debug framework. > > Best regards and thanks, > Simeon It is a paradigm switch - DSF came on the scene a few years before CDI was deprecated and eventually removed. Intro to DSF: https://help.eclipse.org/latest/topic/org.eclipse.cdt.doc.isv/guide/dsf/intro/dsf_programming_intro.html?cp=14_0_5 An example of an extension to DSF-GDB that shows some examples of how you can extend to add additional functionality. The main part of the example shows how to add a "Show GDB Version" command in various places in the UI and how to tie it in to the backend: https://git.eclipse.org/c/cdt/org.eclipse.cdt.git/tree/dsf-gdb/org.eclipse.cdt.examples.dsf.gdb In the past I have done training for companies on DSF migration. I haven't touched it recently, but the github repo is still in place: https://github.com/jonahgraham/cdt-examples I added the presentation that goes with cdt-examples to the repo.
(In reply to Jonah Graham from comment #32) > I added the presentation that goes with cdt-examples to the repo. Wonderful, thank you! I think the slides are all we need: https://github.com/jonahgraham/cdt-examples/blob/cdt_8_6/DSF%20Tutorial.pptx
