Bug 484814 - Login page: Orion logo image needs alt text
Summary: Login page: Orion logo image needs alt text
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Carolyn MacLeod CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2015-12-22 12:13 EST by Carolyn MacLeod CLA
Modified: 2016-01-04 11:15 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carolyn MacLeod CLA 2015-12-22 12:13:52 EST 
<a href="/"><span class="orion-logo">
<img src="images/assets/orion.png" />
</span></a>

Probably should be alt="Orion Home" or similar.
Comment 1 Eclipse Genie CLA 2015-12-22 13:57:10 EST 
New Gerrit change created: https://git.eclipse.org/r/63176
Comment 2 Carolyn MacLeod CLA 2015-12-22 14:12:02 EST 
Turns out there are 5 places where the orion-logo <img> appears.
For 3 of them, I gave alt text of "Orion Home".

The other 2 (landing.html and ServerStatus.html) have a hidden heading:
<h1 class="hide">Orion</h1>

I'm not sure what the intent of the hidden heading is - if it was intended to be there for accessibility, then it is probably better to use alt on the image.

In addition, I noticed that landing.html is missing the <a href="/">
I do not know whether that was intentional.

Anthony, I added you as reviewer because you were involved with the original login experience rework in bug 459158.
Comment 4 Carolyn MacLeod CLA 2016-01-04 11:15:47 EST 
Fixed with change in comment 3.