Bug 484346 - CodeEdit: Consider updating the editor tooltip colour
Summary: CodeEdit: Consider updating the editor tooltip colour
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 11.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 13.0   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
: 490829 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-12-14 13:00 EST by Michael Rennie CLA
Modified: 2016-07-11 06:08 EDT (History)
4 users (show)

See Also:
Silenio_Quarti: review+

Attachments
Updated CSS (1.17 KB, patch)
2015-12-14 13:00 EST, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2015-12-14 13:00:08 EST 
Created attachment 258663 [details]
Updated CSS

Currently the in-editor tooltip colour by default is a teal-like colour with white text. 

A couple of problems with it are:

1. this is harder to read than black text on white background or white text on darker background

2. it doesn't look good

We should consider changing the colour to be a darker shade, perhaps the same colour as the project explorer background. The attached patch changes the colour to be the explorer colour.
Comment 1 Michael Rennie CLA 2015-12-14 14:23:20 EST 
3. The teal actually fails the accessibility audit.

The proposed colour change passes the accessibility audit with a AAA rating.
Comment 2 Steve Northover CLA 2015-12-14 16:42:54 EST 
A few things:

The teal color is used as the background color for popups in other places in the UI.  For example, the help for tooltips in menu items and tool items.  We should not introduce a new background color for "popup things" without getting all the places that are teal.

I see a comment that says " /* Must match the quickfix command button border color */" but I don't see a matching fix for this in the patch.  Did I miss something?

I searched the code base for 325C80 and 158d7a which seem to be color that we are replacing.  There were a bunch of unchanged references.

SSQ very carefully went over all the CSS in Orion and made sure that everything was visible.  He also chose a set of colors that were applied consistently.  We should not make this change at this time unless it is critical and we are consistent and get all the places.  My feeling is that the change can wait.  Sorry.
Comment 3 Michael Rennie CLA 2015-12-15 10:55:18 EST 
(In reply to Steve Northover from comment #2)
>  We should not make this change at this time unless it is
> critical and we are consistent and get all the places.  My feeling is that
> the change can wait.  Sorry.

No worries, we can wait until Silenio is back and decide what we want to change the colours to (since the teal fails accessibility testing it has to change to something).

Its worth noting that many other IDEs use different colours for editor popups vs. tool tips (on actions) vs. selection in lists.
Comment 4 Carolyn MacLeod CLA 2016-04-01 09:36:06 EDT 
*** Bug 490829 has been marked as a duplicate of this bug. ***
Comment 5 Carolyn MacLeod CLA 2016-04-01 09:44:42 EDT 
As mentioned in duplicate bug 490829, please verify that the "Online documentation" link in the content assist popup also passes with the new color.