Bug 484338 - [html] HTML tag matching
Summary: [html] HTML tag matching
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: JS Tools (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 11.0   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-14 12:11 EST by Carolyn MacLeod CLA
Modified: 2016-01-13 13:21 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carolyn MacLeod CLA 2015-12-14 12:11:50 EST
This would be a cool and useful feature. Click (or double-click) in/on an HTML start tag, and the editor matches the corresponding end tag. And vice-versa (click in/on end tag and editor matches start tag).

This is related to, but "bigger than", bug 484336.

Not sure whether component is 'editor' or 'tooling' - probably both.
Comment 1 Curtis Windatt CLA 2015-12-15 10:11:35 EST
I tried implementing something similar treating the matching tags as 'occurrences'.  Difficult to get working correctly as the parser falls on its face if you are missing a close tag.
Comment 2 Curtis Windatt CLA 2016-01-11 17:07:38 EST
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=146812b86bf1b53a4115213dd2497c332b2b1ecb
Implemented with tests

We are having some further discussion on the behaviour.  Such as whether we should mark the name of the tag you are currently working inside (or modifying the attributes of).
Comment 3 Curtis Windatt CLA 2016-01-13 13:21:43 EST
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=cd5a0ef3c7caf61a834d054c84448fee58268bc6
Pushed a change to try a different behaviour, marking tag name whenever you are anywhere inside the tag.