Bug 48336 - [Search] Participants should surface in search progress
Summary: [Search] Participants should surface in search progress
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.1 M2   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-09 07:23 EST by Philipe Mulet CLA
Modified: 2004-09-23 12:29 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2003-12-09 07:23:31 EST 
Build 20031203+JDTCore HEAD patch with search participants

The search progress should surface the participant which is performing.
Comment 1 Jerome Lanneluc CLA 2003-12-09 08:00:38 EST 
Use SearchParticipant.getDescription()
Comment 2 Jerome Lanneluc CLA 2004-05-19 11:30:27 EDT 
Not for 3.0
Comment 3 Jerome Lanneluc CLA 2004-07-06 05:09:49 EDT 
Reopening
Comment 4 Frederic Fusier CLA 2004-07-26 08:16:50 EDT 
Search engine performs search in 2 main steps.
1) Lookup for potential documents in indexes
2) Locate exact and/or potential matches in these documents

So, we'll create a new SubProgressMonitor and initiate 2 subtasks for these 2
steps. Progress monitor dialog will have an additional text under progress bar:
1) {0}: looking for indexes...
2) {0}: locating matches...
where {0} will be search participant description (currently "Java" for
JavaSearchParticipant)

Bar progression has been reviewed to be as appropriate as possible whatever the
number of found matches:
 - items total is the number of indexed documents with possible matches we got 
   in step 1.
 - number of increments will be volontary limitated due to the fact that 
   refreshing progress bar may consume lot of time during the search.
   For example, refresh progress bar for each document multiplies search time
   by 4!...
   The rule for increments number will be:
     + 0-399: 2
     + 400-599: 3
     + 600-999: 4
     + >1000: (total/1000) * 5
   This rule will make time to refresh progress bar small regarding to global
   search time...
Comment 5 Frederic Fusier CLA 2004-07-26 10:25:29 EDT 
Fixed and released in HEAD.

No test case added as it concern Progress dialog...
Only verify that all JDT/Core and JDT/UI tests pass.
Comment 6 Frederic Fusier CLA 2004-07-26 12:17:56 EDT 
Additional messages have been modified as follows:
1) {0}: lookup indexes...
2) {0}: locate matches...
Comment 7 David Audel CLA 2004-09-23 12:29:00 EDT 
Verified in I200409230100.