Bug 483034 - Assert on wrong object?
Summary: Assert on wrong object?
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: terminal (show other bugs)
Version: Next   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-25 14:27 EST by Lothar Kunz CLA
Modified: 2020-09-04 15:12 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lothar Kunz CLA 2015-11-25 14:27:38 EST
Hello,

I am just wondering, if the following line in the LaunchTerminalHandler class from the package org.eclipse.tm.terminal.view.ui.rse.internal. is wrong?

if (dialog.open() == Window.OK) {
// Get the terminal settings from the dialog
Map<String, Object> properties = dialog.getSettings();
if (properties != null) {
String delegateId = (String)properties.get(ITerminalsConnectorConstants.PROP_DELEGATE_ID);
Assert.isNotNull(delegateId);
ILauncherDelegate delegate = LauncherDelegateManager.getInstance().getLauncherDelegate(delegateId, false);
Assert.isNotNull(delegateId);    <-------------IS HERE THE ASSERT ON THE WRONG OBJEECT AND SHOULD BE delegate?
delegate.execute(properties, null);
}

Best,

Lothar
Comment 1 Jonah Graham CLA 2020-05-01 10:09:41 EDT
The Terminal component of the Eclipse Ecosystem has a new home. The Terminal is now part of the Eclipse CDT project[1].

This change means a new Git repo[2], P2 site[3] and Bugzilla component. The terminal will continue to be delivered as part of the quarterly Simultaneous Release of Eclipse as well.

The marketplace entry[4] had not been updated in a few years. It will once again install the latest release of the terminal on the latest release of the whole IDE (currently 2020-03).

If this bug is no longer relevant, please feel free to comment or close the bug. If you can confirm if this issues still occurs in the latest release please do let me know in a comment.

[1] https://wiki.eclipse.org/CDT/User/NewIn911
[2] https://git.eclipse.org/c/cdt/org.eclipse.cdt.git (in the terminal directory)
[3] current release is 9.11 - P2 site https://download.eclipse.org/tools/cdt/releases/9.11/
[4] https://marketplace.eclipse.org/content/tm-terminal

(This comment was added to all open terminal bugs along with changing the Product/component pair to CDT/terminal.)