Bug 483027 - "Rebase" action does not keep dependencies
Summary: "Rebase" action does not keep dependencies
Status: RESOLVED FIXED
Alias: None
Product: Egerrit
Classification: Technology
Component: Editor UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 major
Target Milestone: 1.0   Edit
Assignee: Guy Perron CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-25 13:17 EST by Marc Khouzam CLA
Modified: 2016-05-03 15:04 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Khouzam CLA 2015-11-25 13:17:23 EST
When I use the 'rebase' action for a review that depends on another, if I leave the rebase dialog empty, the rebase is done on the branch, not on the new version of the dependency.  WebGerrit does not behave like this.

1- Create two commits on master, one based on the other.
2- Push the top commit to Gerrit.  This will create two reviews which depend on each other.
3- Create a second patchset for review 1 (push a new commit, or edit on webGerrit)
4- in review 2, press 'rebase' and leave the dialog empty

=> review 2 will now be directly on master instead of on top of review 1

This is not what happens in webGerrit.
Comment 1 Eclipse Genie CLA 2016-05-02 17:49:50 EDT
New Gerrit change created: https://git.eclipse.org/r/71840
Comment 3 Pascal Rapicault CLA 2016-05-03 15:04:32 EDT
fixed in > 467