Bug 482977 - Sphinx Handling of intrinsic model checks broken?
Summary: Sphinx Handling of intrinsic model checks broken?
Status: CLOSED WONTFIX
Alias: None
Product: Sphinx
Classification: Automotive
Component: Core (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Windows NT
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-25 04:28 EST by Andreas Graf CLA
Modified: 2024-05-06 23:20 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Graf CLA 2015-11-25 04:28:02 EST 
I think that the handling of intrinsic model checks is broken.

org.eclipse.sphinx.emf.check.AbstractCheckValidator.validate(EClass, EObject, DiagnosticChain, Map<Object, Object>)

has code

if (helper.areIntrinsicModelIntegrityConstraintsEnabled()) {

Can this ever be true?

org.eclipse.sphinx.emf.check.CompositeValidator.validate(EClass, EObject, DiagnosticChain, Map<Object, Object>)

calls handler.preValidate where  helper.removeEnableIntrinsicModelIntegrityConstraintsOption();

is called So can this ever be relevant?

We noted this, because the default Artop ecuc constraint do not get exectued when doing a check based validation on them and activationg the "intrinsic" checks.
Comment 1 Balazs Grill CLA 2024-05-06 23:20:30 EDT 
Closed stale issue before migration