Bug 482528 - Add support for properties view specification
Summary: Add support for properties view specification
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Properties (show other bugs)
Version: 3.0.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.0.0   Edit
Assignee: Pierre-Charles David CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks: 492985 495366
  Show dependency tree
 
Reported: 2015-11-18 15:32 EST by Pierre-Charles David CLA
Modified: 2016-06-24 08:01 EDT (History)
3 users (show)

See Also:


Attachments
fieldsAlignmentAndStatusBarProblem.png (20.35 KB, image/png)
2016-05-27 05:27 EDT, Laurent Redor CLA
no flags Details
fieldsAlignmentProblemRC2.png (7.30 KB, image/png)
2016-05-27 05:27 EDT, Laurent Redor CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre-Charles David CLA 2015-11-18 15:32:28 EST
We want the nice look and feel of EEF property views available to all Sirius-based modelers, with:
* good defaults: zero configuration to get a "good enough" result in most cases;
* comparable power and ease of configuration as the rest of Sirius (diagrams & co) when custom rules are needed.

The configuration, when needed, should be integrated with the existing Sirius features, i.e. specified from inside the VSMs, with the same/similar concepts as for existing dialects, and fully dynamic (no code generation, immediate effect on VSM change).
Comment 1 Eclipse Genie CLA 2015-11-23 06:10:37 EST
New Gerrit change created: https://git.eclipse.org/r/61001
Comment 3 Eclipse Genie CLA 2015-11-26 05:18:45 EST
New Gerrit change created: https://git.eclipse.org/r/61314

WARNING: this patchset contains 1696 new lines of code and requires a Contribution Questionnaire (CQ), as author stephane.begaudeau@obeo.fr is not a committer on sirius/org.eclipse.sirius. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Comment 5 Eclipse Genie CLA 2015-12-01 11:50:22 EST
New Gerrit change created: https://git.eclipse.org/r/61680
Comment 6 Eclipse Genie CLA 2015-12-16 05:10:33 EST
New Gerrit change created: https://git.eclipse.org/r/62804
Comment 8 Eclipse Genie CLA 2016-01-12 04:22:25 EST
New Gerrit change created: https://git.eclipse.org/r/64101
Comment 10 Eclipse Genie CLA 2016-01-18 11:18:29 EST
New Gerrit change created: https://git.eclipse.org/r/64575
Comment 11 Eclipse Genie CLA 2016-01-18 11:18:31 EST
New Gerrit change created: https://git.eclipse.org/r/64574
Comment 12 Eclipse Genie CLA 2016-01-18 11:18:32 EST
New Gerrit change created: https://git.eclipse.org/r/64573
Comment 13 Eclipse Genie CLA 2016-01-21 04:37:32 EST
New Gerrit change created: https://git.eclipse.org/r/64843
Comment 16 Eclipse Genie CLA 2016-01-21 11:06:53 EST
New Gerrit change created: https://git.eclipse.org/r/64897
Comment 17 Eclipse Genie CLA 2016-01-21 11:06:54 EST
New Gerrit change created: https://git.eclipse.org/r/64896
Comment 18 Eclipse Genie CLA 2016-01-22 10:57:07 EST
New Gerrit change created: https://git.eclipse.org/r/65006
Comment 20 Eclipse Genie CLA 2016-01-25 10:41:05 EST
New Gerrit change created: https://git.eclipse.org/r/65110
Comment 22 Eclipse Genie CLA 2016-01-27 08:46:01 EST
New Gerrit change created: https://git.eclipse.org/r/65264
Comment 28 Eclipse Genie CLA 2016-01-28 04:22:23 EST
New Gerrit change created: https://git.eclipse.org/r/65338
Comment 30 Eclipse Genie CLA 2016-01-28 08:20:31 EST
New Gerrit change created: https://git.eclipse.org/r/65356
Comment 31 Eclipse Genie CLA 2016-01-28 08:22:13 EST
New Gerrit change created: https://git.eclipse.org/r/65357
Comment 35 Eclipse Genie CLA 2016-02-01 09:04:08 EST
New Gerrit change created: https://git.eclipse.org/r/65557
Comment 37 Eclipse Genie CLA 2016-02-02 03:59:19 EST
New Gerrit change created: https://git.eclipse.org/r/65627
Comment 38 Eclipse Genie CLA 2016-02-02 04:01:56 EST
New Gerrit change created: https://git.eclipse.org/r/65630
Comment 43 Eclipse Genie CLA 2016-02-02 10:29:28 EST
New Gerrit change created: https://git.eclipse.org/r/65698
Comment 44 Eclipse Genie CLA 2016-02-02 10:29:29 EST
New Gerrit change created: https://git.eclipse.org/r/65697
Comment 45 Eclipse Genie CLA 2016-02-02 11:09:34 EST
New Gerrit change created: https://git.eclipse.org/r/65708
Comment 46 Eclipse Genie CLA 2016-02-03 05:44:25 EST
New Gerrit change created: https://git.eclipse.org/r/65774
Comment 51 Eclipse Genie CLA 2016-02-04 08:27:14 EST
New Gerrit change created: https://git.eclipse.org/r/65886
Comment 54 Eclipse Genie CLA 2016-02-05 05:26:45 EST
New Gerrit change created: https://git.eclipse.org/r/65999
Comment 55 Eclipse Genie CLA 2016-02-05 05:27:10 EST
New Gerrit change created: https://git.eclipse.org/r/66000
Comment 56 Eclipse Genie CLA 2016-02-09 10:57:28 EST
New Gerrit change created: https://git.eclipse.org/r/66212
Comment 59 Eclipse Genie CLA 2016-02-10 09:20:34 EST
New Gerrit change created: https://git.eclipse.org/r/66307
Comment 60 Eclipse Genie CLA 2016-02-10 11:20:12 EST
New Gerrit change created: https://git.eclipse.org/r/66321
Comment 62 Eclipse Genie CLA 2016-02-11 05:27:45 EST
New Gerrit change created: https://git.eclipse.org/r/66374
Comment 63 Eclipse Genie CLA 2016-02-11 10:47:32 EST
New Gerrit change created: https://git.eclipse.org/r/66405
Comment 68 Eclipse Genie CLA 2016-02-16 10:26:36 EST
New Gerrit change created: https://git.eclipse.org/r/66699
Comment 70 Eclipse Genie CLA 2016-02-17 10:13:22 EST
New Gerrit change created: https://git.eclipse.org/r/66748
Comment 72 Eclipse Genie CLA 2016-02-18 11:17:46 EST
New Gerrit change created: https://git.eclipse.org/r/66848
Comment 74 Eclipse Genie CLA 2016-02-19 09:16:51 EST
New Gerrit change created: https://git.eclipse.org/r/66930
Comment 76 Eclipse Genie CLA 2016-02-22 09:24:27 EST
New Gerrit change created: https://git.eclipse.org/r/67055
Comment 77 Eclipse Genie CLA 2016-02-22 10:09:55 EST
New Gerrit change created: https://git.eclipse.org/r/67059
Comment 78 Eclipse Genie CLA 2016-02-22 10:17:38 EST
New Gerrit change created: https://git.eclipse.org/r/67065
Comment 81 Eclipse Genie CLA 2016-02-25 05:04:09 EST
New Gerrit change created: https://git.eclipse.org/r/67315
Comment 82 Eclipse Genie CLA 2016-02-26 10:28:49 EST
New Gerrit change created: https://git.eclipse.org/r/67428
Comment 83 Eclipse Genie CLA 2016-02-26 10:28:52 EST
New Gerrit change created: https://git.eclipse.org/r/67425
Comment 84 Eclipse Genie CLA 2016-02-26 10:28:55 EST
New Gerrit change created: https://git.eclipse.org/r/67426
Comment 85 Eclipse Genie CLA 2016-02-26 10:28:56 EST
New Gerrit change created: https://git.eclipse.org/r/67424
Comment 86 Eclipse Genie CLA 2016-02-26 10:28:58 EST
New Gerrit change created: https://git.eclipse.org/r/67427
Comment 91 Eclipse Genie CLA 2016-03-03 08:43:58 EST
New Gerrit change created: https://git.eclipse.org/r/67739
Comment 93 Pierre-Charles David CLA 2016-03-07 11:42:12 EST
Removing the many auto-added "See also" links.
Comment 94 Eclipse Genie CLA 2016-03-16 12:36:44 EDT
New Gerrit change created: https://git.eclipse.org/r/68552
Comment 98 Eclipse Genie CLA 2016-03-29 09:26:53 EDT
New Gerrit change created: https://git.eclipse.org/r/69431
Comment 100 Eclipse Genie CLA 2016-03-30 05:32:58 EDT
New Gerrit change created: https://git.eclipse.org/r/69505
Comment 102 Eclipse Genie CLA 2016-03-30 10:38:30 EDT
New Gerrit change created: https://git.eclipse.org/r/69535
Comment 103 Eclipse Genie CLA 2016-03-30 12:04:45 EDT
New Gerrit change created: https://git.eclipse.org/r/69545
Comment 107 Eclipse Genie CLA 2016-03-31 10:34:35 EDT
New Gerrit change created: https://git.eclipse.org/r/69633
Comment 108 Eclipse Genie CLA 2016-03-31 10:34:47 EDT
New Gerrit change created: https://git.eclipse.org/r/69634
Comment 109 Eclipse Genie CLA 2016-04-01 05:46:20 EDT
New Gerrit change created: https://git.eclipse.org/r/69693
Comment 110 Eclipse Genie CLA 2016-04-06 04:38:04 EDT
New Gerrit change created: https://git.eclipse.org/r/69990
Comment 113 Eclipse Genie CLA 2016-04-08 04:57:46 EDT
New Gerrit change created: https://git.eclipse.org/r/70215
Comment 115 Eclipse Genie CLA 2016-04-12 06:04:37 EDT
New Gerrit change created: https://git.eclipse.org/r/70453
Comment 116 Eclipse Genie CLA 2016-04-12 12:02:38 EDT
New Gerrit change created: https://git.eclipse.org/r/70493
Comment 117 Eclipse Genie CLA 2016-04-14 03:58:21 EDT
New Gerrit change created: https://git.eclipse.org/r/70616
Comment 118 Eclipse Genie CLA 2016-04-14 09:32:54 EDT
New Gerrit change created: https://git.eclipse.org/r/70650
Comment 119 Eclipse Genie CLA 2016-04-18 04:12:55 EDT
New Gerrit change created: https://git.eclipse.org/r/70837
Comment 120 Eclipse Genie CLA 2016-04-19 11:50:08 EDT
New Gerrit change created: https://git.eclipse.org/r/70977
Comment 122 Eclipse Genie CLA 2016-04-20 08:01:09 EDT
New Gerrit change created: https://git.eclipse.org/r/71062
Comment 124 Eclipse Genie CLA 2016-04-25 04:06:00 EDT
New Gerrit change created: https://git.eclipse.org/r/71311
Comment 125 Eclipse Genie CLA 2016-04-25 09:37:24 EDT
New Gerrit change created: https://git.eclipse.org/r/71329
Comment 131 Eclipse Genie CLA 2016-04-29 07:50:18 EDT
New Gerrit change created: https://git.eclipse.org/r/71681
Comment 132 Eclipse Genie CLA 2016-04-29 09:48:31 EDT
New Gerrit change created: https://git.eclipse.org/r/71693
Comment 133 Eclipse Genie CLA 2016-04-29 12:01:30 EDT
New Gerrit change created: https://git.eclipse.org/r/71716
Comment 134 Eclipse Genie CLA 2016-05-03 05:35:20 EDT
New Gerrit change created: https://git.eclipse.org/r/71874
Comment 138 Eclipse Genie CLA 2016-05-04 03:41:20 EDT
New Gerrit change created: https://git.eclipse.org/r/71977
Comment 140 Eclipse Genie CLA 2016-05-04 09:46:27 EDT
New Gerrit change created: https://git.eclipse.org/r/72034
Comment 142 Eclipse Genie CLA 2016-05-04 10:12:48 EDT
New Gerrit change created: https://git.eclipse.org/r/72036
Comment 145 Eclipse Genie CLA 2016-05-12 09:35:29 EDT
New Gerrit change created: https://git.eclipse.org/r/72626
Comment 146 Eclipse Genie CLA 2016-05-12 09:35:36 EDT
New Gerrit change created: https://git.eclipse.org/r/72627
Comment 147 Eclipse Genie CLA 2016-05-12 09:35:38 EDT
New Gerrit change created: https://git.eclipse.org/r/72629
Comment 148 Eclipse Genie CLA 2016-05-12 09:35:40 EDT
New Gerrit change created: https://git.eclipse.org/r/72628
Comment 149 Eclipse Genie CLA 2016-05-12 09:35:42 EDT
New Gerrit change created: https://git.eclipse.org/r/72625
Comment 150 Eclipse Genie CLA 2016-05-13 08:43:38 EDT
New Gerrit change created: https://git.eclipse.org/r/72710
Comment 151 Eclipse Genie CLA 2016-05-13 08:43:45 EDT
New Gerrit change created: https://git.eclipse.org/r/72708
Comment 152 Eclipse Genie CLA 2016-05-13 08:43:47 EDT
New Gerrit change created: https://git.eclipse.org/r/72709
Comment 153 Eclipse Genie CLA 2016-05-13 08:43:49 EDT
New Gerrit change created: https://git.eclipse.org/r/72711
Comment 154 Eclipse Genie CLA 2016-05-13 09:20:10 EDT
New Gerrit change created: https://git.eclipse.org/r/72717
Comment 155 Eclipse Genie CLA 2016-05-13 09:36:18 EDT
New Gerrit change created: https://git.eclipse.org/r/72718
Comment 156 Eclipse Genie CLA 2016-05-13 09:41:40 EDT
New Gerrit change created: https://git.eclipse.org/r/72719
Comment 157 Eclipse Genie CLA 2016-05-13 10:48:06 EDT
New Gerrit change created: https://git.eclipse.org/r/72729
Comment 158 Eclipse Genie CLA 2016-05-17 09:47:48 EDT
New Gerrit change created: https://git.eclipse.org/r/72923
Comment 172 Eclipse Genie CLA 2016-05-19 05:21:10 EDT
New Gerrit change created: https://git.eclipse.org/r/73139
Comment 173 Eclipse Genie CLA 2016-05-19 08:10:54 EDT
New Gerrit change created: https://git.eclipse.org/r/73157
Comment 175 Eclipse Genie CLA 2016-05-19 09:07:01 EDT
New Gerrit change created: https://git.eclipse.org/r/73166
Comment 176 Eclipse Genie CLA 2016-05-19 09:23:16 EDT
New Gerrit change created: https://git.eclipse.org/r/73167
Comment 180 Eclipse Genie CLA 2016-05-19 11:31:10 EDT
New Gerrit change created: https://git.eclipse.org/r/73190
Comment 182 Eclipse Genie CLA 2016-05-20 09:22:42 EDT
New Gerrit change created: https://git.eclipse.org/r/73286
Comment 183 Eclipse Genie CLA 2016-05-20 09:59:19 EDT
New Gerrit change created: https://git.eclipse.org/r/73293
Comment 186 Pierre-Charles David CLA 2016-05-24 09:14:54 EDT
Closing as resolved, even if it will be a first iteration in 4.0. More work on this subject is planned for 4.1. Bug #490604 which corresponds to the documentation of this feature is still being worked on.
Comment 187 Pierre-Charles David CLA 2016-05-24 09:19:53 EDT
Removing the many references to gerrit patches and commits which pollute the page. The gerrit changes corresponding to this ticket can be seen at https://git.eclipse.org/r/#/q/project:sirius/org.eclipse.sirius+message:%22Bug:+482528%22.
Comment 188 Eclipse Genie CLA 2016-05-27 04:30:39 EDT
New Gerrit change created: https://git.eclipse.org/r/73790
Comment 189 Laurent Redor CLA 2016-05-27 05:19:29 EDT
There is no indication about this new feature in the release notes and no explanation on how to install it.

After installation, the documentation about this new feature is present but:
* There are 2 entries "Properties View" in the table of contents. Only one is necessary.
* There is nothing about the default behavior (only the installation is enough to have "new properties view" without modifying the VSM). 
* The hyperlinks to other documentation references are false (Group, VSM, ...).
* In the documentation, in the first description of "Properties View Description", there is nothing about the "Group Descriptions" but a little further, there is "groups represent properties view Section which can contain controls."
* Blank entries for "validation rules" chapter
Comment 190 Laurent Redor CLA 2016-05-27 05:26:43 EDT
Sorry the comment 189 is wrong (it was for bug 490604). The right one is:

Issues detected during validation:
* If you just install  "Sirius Properties Views - Runtime Support (Experimental)" and "    Sirius Properties Views - Specifier Support (Experimental)" you just have the "General" tab in the properties view. Other tabs (like Advanced, Appearance, Style, ...) disappear. I think that a dependency should be added to automatically get other EEF needed features.
* The fields are not correctly align (see screenshot fieldsAlignmentAndStatusBarProblem.png). Seems better is RC2, only one pixel (fieldsAlignmentProblemRC2.png).
* The "tooltip" displayed in the status bar does not match with the current selection (when you select a field in the General tab). It matches with the last selection made in another tab (see screenshot fieldsAlignmentAndStatusBarProblem.png).
* When you click "..." for the Metamodels field of a "Properties View Description" nothing is proposed.
* Globally, in VSM, there is no tooltip on properties of new VSM elements concerning this feature (contrary to other properties of existing VSM elements).
* Completion problem, example: On a Group with "basicfamily.Man" as "Domain Class" there is no completion with "feature:" for "Semantic Candidate Expression" (idem for all properties of widgets of this group).
* I've not tested all widgets, all styles but rather the feature in overview. There is perhaps other problems but it is an experimental feature.
Comment 191 Laurent Redor CLA 2016-05-27 05:27:05 EDT
Created attachment 262055 [details]
fieldsAlignmentAndStatusBarProblem.png
Comment 192 Laurent Redor CLA 2016-05-27 05:27:19 EDT
Created attachment 262056 [details]
fieldsAlignmentProblemRC2.png
Comment 194 Pierre-Charles David CLA 2016-05-30 05:07:22 EDT
(In reply to Laurent Redor from comment #190)
> Sorry the comment 189 is wrong (it was for bug 490604). The right one is:
> 
> Issues detected during validation:
> * If you just install  "Sirius Properties Views - Runtime Support
> (Experimental)" and "    Sirius Properties Views - Specifier Support
> (Experimental)" you just have the "General" tab in the properties view.
> Other tabs (like Advanced, Appearance, Style, ...) disappear. I think that a
> dependency should be added to automatically get other EEF needed features.

This one should be fixed by https://git.eclipse.org/r/#/c/73790/. I'll test it on an actual product before closing this.

> * The fields are not correctly align (see screenshot
> fieldsAlignmentAndStatusBarProblem.png). Seems better is RC2, only one pixel
> (fieldsAlignmentProblemRC2.png).
> * The "tooltip" displayed in the status bar does not match with the current
> selection (when you select a field in the General tab). It matches with the
> last selection made in another tab (see screenshot
> fieldsAlignmentAndStatusBarProblem.png).
> * When you click "..." for the Metamodels field of a "Properties View
> Description" nothing is proposed.
> * Globally, in VSM, there is no tooltip on properties of new VSM elements
> concerning this feature (contrary to other properties of existing VSM
> elements).
> * Completion problem, example: On a Group with "basicfamily.Man" as "Domain
> Class" there is no completion with "feature:" for "Semantic Candidate
> Expression" (idem for all properties of widgets of this group).
> * I've not tested all widgets, all styles but rather the feature in
> overview. There is perhaps other problems but it is an experimental feature.

I'll open individual tickets for these and we'll try to fix them for 4.1. Thanks for the feedback.
Comment 195 Pierre-Charles David CLA 2016-05-30 08:31:05 EDT
(In reply to Pierre-Charles David from comment #194)
> (In reply to Laurent Redor from comment #190)
> > Sorry the comment 189 is wrong (it was for bug 490604). The right one is:
> > 
> > Issues detected during validation:
> > * If you just install  "Sirius Properties Views - Runtime Support
> > (Experimental)" and "    Sirius Properties Views - Specifier Support
> > (Experimental)" you just have the "General" tab in the properties view.
> > Other tabs (like Advanced, Appearance, Style, ...) disappear. I think that a
> > dependency should be added to automatically get other EEF needed features.
> 
> This one should be fixed by https://git.eclipse.org/r/#/c/73790/. I'll test
> it on an actual product before closing this.

Confirmed fixed:
1. Installed Sirius with Properties Viuew support on an Eclipse SDK package (currently RC2, *without* the patch mentioned above), and Ecore Tools.
2. Created a simple Ecore diagram => only the "General" tab is visible (KO).
3. Added the Sirius nightlies update sites and "Check for Update", which upgrades to a pre-RC3 version of Sirius with the fix above.
4. Restart and reopen the diagram: all the tabs are visible ("General" and all the "legacy" ones): OK.
Comment 196 Eclipse Genie CLA 2016-05-30 10:03:17 EDT
New Gerrit change created: https://git.eclipse.org/r/73944
Comment 197 Eclipse Genie CLA 2016-05-30 10:03:38 EDT
New Gerrit change created: https://git.eclipse.org/r/73943
Comment 200 Pierre-Charles David CLA 2016-06-24 08:01:07 EDT
Available in Sirius 4.0.0.