Bug 482080 - Diagram editor (and possibly others) no longer contributed by the main oes.diagram.ui plugin
Summary: Diagram editor (and possibly others) no longer contributed by the main oes.di...
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Core (show other bugs)
Version: 3.0.0   Edit
Hardware: All All
: P3 critical (vote)
Target Milestone: 3.1.3   Edit
Assignee: Laurent Redor CLA
QA Contact: Florian Barbin CLA
URL:
Whiteboard:
Keywords: triaged
Depends on: 482029 482081
Blocks:
  Show dependency tree
 
Reported: 2015-11-13 03:34 EST by Pierre-Charles David CLA
Modified: 2015-12-15 05:26 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre-Charles David CLA 2015-11-13 03:34:10 EST 
+++ This bug was initially created as a clone of Bug #482029 +++

See https://www.eclipse.org/forums/index.php/mv/msg/1072080/1714402/#msg_1714402 for reference.

I'll reproduce my response on the forum (this interpretation was confirmed by the original reporter):

This looks like an unintended side-effect of bug #456771 "Split UI 
contributions into optional plug-ins", where we moved most UI-related 
contributions (via the various plugin.xml) into new plug-ins. The idea 
was to allow people to consume the core of Sirius without having all the 
UI contributions enabled (all the views, perspectives, context menus etc.).

Apparently we were a little overzealous and moved the editor 
contribution too, even though its registration does not risk cluttering 
the UI and is not optional (like you discovered).

For the time being, a simple fix on you side would be to add an explicit 
dependency towards org.eclipse.sirius.diagram.ui.ext (and all the new 
*.ext plug-ins for that matter), and confirm if this fixes your issue. 
If it does, we'll reopen the ticket (or create a new one) to fix this 
and review the other changes made for #456771 for potential similar issues.

Note that this should not affect people who depend the Sirius features 
(as opposed to individual plug-ins), and the features in 3.0 include the 
new *.ext plug-ins.
Comment 1 Laurent Redor CLA 2015-11-18 13:08:06 EST 
The editors declarations will be moved again in original plugins (as it was before bug #482029).

The other extensions, moved during bug #482029, will be kept in "ext plugins":
* Preference pages (diagram pref pages, Sirius peference pages)
* View (Interpreter view, model explorer view)
* Popup menus
* Wizards
* Menus
Comment 2 Eclipse Genie CLA 2015-11-18 13:15:26 EST 
New Gerrit change created: https://git.eclipse.org/r/60734
Comment 5 Florian Barbin CLA 2015-11-20 10:02:00 EST 
Verified on Sirius 3.1.3.201511201007. The plugin.xml of org.eclipse.sirius.diagram.ui now declares the Diagram editor.
Comment 6 Pierre-Charles David CLA 2015-12-15 05:26:32 EST 
Available in Sirius 3.1.3 released on 2015-12-08.