Bug 481955 - References dropdown filter has a hidden button
Summary: References dropdown filter has a hidden button
Status: CLOSED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Git (show other bugs)
Version: 11.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Xintong Wang CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2015-11-11 14:31 EST by Xintong Wang CLA
Modified: 2015-12-11 10:23 EST (History)
4 users (show)

See Also:

Attachments
the btn only appears when hovered (5.49 KB, image/png)
2015-11-11 14:31 EST, Xintong Wang CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xintong Wang CLA 2015-11-11 14:31:16 EST 
Created attachment 257882 [details]
the btn only appears when hovered

Open the references dropdown and mouseover the right side or the filter input box. There is a hidden button which only shows when moused over. I think this is the search button and acts the same way as pressing enter when filtering for something.
Comment 1 Carolyn MacLeod CLA 2015-11-11 14:52:49 EST 
I agree that this is unexpected. (I believe it's supposed to be a "funnel" for filtering ;)

For accessibility purposes, the button should be separate, and visible, and not magically appear on hover. It should also have an aria-label, and a proper tooltip, and it should not have tabindex="-1" (i.e. tabindex should be left as the default for button, which is 0).

I would also like to see an 'x' button (with an aria-label of "clear") as a convenience to clear the filter (I opened bug 481471 for that).
Comment 2 Xintong Wang CLA 2015-11-11 15:02:40 EST 
(In reply to Carolyn MacLeod from comment #1)
> I agree that this is unexpected. (I believe it's supposed to be a "funnel"
> for filtering ;)
> 
> For accessibility purposes, the button should be separate, and visible, and
> not magically appear on hover. It should also have an aria-label, and a
> proper tooltip, and it should not have tabindex="-1" (i.e. tabindex should
> be left as the default for button, which is 0).
> 
> I would also like to see an 'x' button (with an aria-label of "clear") as a
> convenience to clear the filter (I opened bug 481471 for that).

I am looking into that, found this along the way...
Comment 3 Carolyn MacLeod CLA 2015-11-11 15:08:02 EST 
Cool. Let's get some more feedback before you make changes...

SSQ, Grant, please comment on this proposal to change the Reference dropdown's filter text UI as follows:

   [Filter items     ] [funnel] [x]

I would also want the filter text to take focus when the Reference is initially dropped down (bug 481744), so that the user can just start typing.

Also, (maybe) down arrow key could navigate to the list.
Ideally, this would be like an autocomplete... but that is for a different bug.  :)
Comment 4 Xintong Wang CLA 2015-11-11 15:13:33 EST 
For HTML5 supported browsers, i think the following would be better since inputs have built in "search" type which will automatically show an "x" when used. (e.g. <input type="search" />)

[Filter items     [x]] [funnel]
Comment 5 Carolyn MacLeod CLA 2015-11-11 16:12:26 EST 
Nice one, Xintong. Agreed.
Comment 6 Carolyn MacLeod CLA 2015-11-11 16:35:14 EST 
Another nice thing about using input type="search" is that the ESC key clears the text field. (Handy for keyboard users).
Comment 7 Carolyn MacLeod CLA 2015-11-11 17:01:06 EST 
Note that x and Esc currently only work on Chrome and Safari for input type="search".

Firefox just treats it like a text input (for now):
https://bugzilla.mozilla.org/show_bug.cgi?id=558594
https://bugzilla.mozilla.org/show_bug.cgi?id=1055085
Comment 8 Eclipse Genie CLA 2015-11-19 15:12:55 EST 
New Gerrit change created: https://git.eclipse.org/r/60826