Bug 481812 - Direct edit label precondition behavior is not consistent
Summary: Direct edit label precondition behavior is not consistent
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 3.0.0   Edit
Hardware: PC Windows NT
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2015-11-10 04:23 EST by Daria Tioc-Deac CLA
Modified: 2017-05-09 02:44 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daria Tioc-Deac CLA 2015-11-10 04:23:50 EST 
Direct edit label precondition behavior is not consistent. For diagram elements that are containers, if the direct edit precondition is evaluated to false, the edit box for the label is not displayed at all if the user tries to perform a direct edit. For diagram elements that are nodes, the edit box is displayed, the user can input some text, but the edit does not take effect when the user presses Enter.
Comment 1 Maxime Porhel CLA 2015-11-18 16:30:56 EST 
DirectEditCommandBuilder.canDirectEdit() is called during buildCommand() and also in org.eclipse.sirius.diagram.ui.edit.api.part.AbstractDiagramNameEditPart.isDirectEditEnabled(). 

It is not called in the DNode with "node" label position. 

Additional check:
When the position is set to "border" there is a NodeNameEditPart we should retrieve the same behavior than the container, when the label of the node is selected.

Homologation scenario will be created during correct as support for unit tests
Comment 2 Niels Brouwers CLA 2016-11-21 08:05:47 EST 
Concluding from the comments added by Obeo, the fix seems trivial. Any chance it can come with the next release of Sirius?
Comment 3 Niels Brouwers CLA 2017-05-09 02:44:56 EDT 
Any update on this issue?