Bug 481674 - Settings page aria-labelledby 'Navigation-header' doesn't exist
Summary: Settings page aria-labelledby 'Navigation-header' doesn't exist
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Carolyn MacLeod CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2015-11-08 22:58 EST by Carolyn MacLeod CLA
Modified: 2015-11-10 23:23 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carolyn MacLeod CLA 2015-11-08 22:58:05 EST 
In file settings/Subsection.js the subsection's aria-labelledby attribute is set to 'Navigation-header', but there isn't any element with 'Navigation-header' id.

The titleNode element is probably the element that was intended to be the label for the section, however if all titleNode elements were given an id of 'Navigation-header' then the id would not be unique.

The patch creates a unique id based on sectionName (which is the text for the titleNode element).
Comment 1 Eclipse Genie CLA 2015-11-08 23:03:34 EST 
New Gerrit change created: https://git.eclipse.org/r/59917
Comment 3 Carolyn MacLeod CLA 2015-11-10 23:23:23 EST 
Fixed by commit in comment 2.