Bug 481292 - "Polish" API of SelectionModel
Summary: "Polish" API of SelectionModel
Status: RESOLVED FIXED
Alias: None
Product: GEF
Classification: Tools
Component: GEF MVC (show other bugs)
Version: 0.2.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.0.0 / 3.11.0 (Neon) M3   Edit
Assignee: Alexander Nyßen CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-03 04:18 EST by Alexander Nyßen CLA
Modified: 2015-11-03 04:38 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Nyßen CLA 2015-11-03 04:18:57 EST 
The naming of methods in the selection model seems to be misleading for clients. We should adjust these to be easier to comprehend, ensuring also that things are comparable to the naming within HoverModel and FocusModel.
Comment 1 Alexander Nyßen CLA 2015-11-03 04:38:08 EST 
I pushed the following changes to origin/master.

- Renamed updateSelection() to setSelection().
- Renamed appendSelection() to appendToSelection() and adjusted its implementation to be complementary to prependSelection().
- Renamed select() to prependToSelection().
- Renamed deselectAll() to clearSelection().
- Renamed deselect() to removeFromSelection().
- Renamed getSelected() to getSelection().
- Removed internal set representation, which was unneccessary.
- Updated javadoc to be more explicit and concise.
- Added SelectionModelTests to mvc test bundle.

Resolving as fixed in 3.11.0 M3.