Bug 481200 - Animation not working on Mac OS X
Summary: Animation not working on Mac OS X
Status: NEW
Alias: None
Product: GEF
Classification: Tools
Component: GEF-Legacy Draw2d (show other bugs)
Version: 3.11.0   Edit
Hardware: Macintosh Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-01 18:12 EST by Phil Beauvoir CLA
Modified: 2017-10-19 12:47 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Phil Beauvoir CLA 2015-11-01 18:12:32 EST
Animation does not work on Mac OS X (again).

Eclipe 4.5.1
GEF 3.10.1
OS X 10.11.1

For steps to reproduce, see bug #135352
Comment 1 Alexander Nyßen CLA 2015-11-17 07:18:56 EST
As we have not change the Draw2d/GEF code base to this extend, I fear its an SWT regression that has been introduced. Can you please file a bug against SWT (or re-open the appropriate one underlying bug #135352)?
Comment 2 Phil Beauvoir CLA 2015-11-17 17:55:09 EST
(In reply to Alexander Nyßen from comment #1)
> As we have not change the Draw2d/GEF code base to this extend, I fear its an
> SWT regression that has been introduced. Can you please file a bug against
> SWT (or re-open the appropriate one underlying bug #135352)?

I would open a new SWT bug but I don't know where to begin to describe it in SWT terms. Is it a problem with "update() does not flush paints" as in bug #193362, or is it something else?
Comment 3 Phil Beauvoir CLA 2017-09-21 08:36:12 EDT
Updated to Eclipse 4.7.0, GEF 3.11.

Animations worked on Mac version for Eclipse 4.6.x (Neon) but not 4.7.0 (Oxygen)
Comment 4 Alexander Nyßen CLA 2017-09-21 09:10:36 EDT
Sounds like an SWT regression...
Comment 5 Phil Beauvoir CLA 2017-09-21 09:27:06 EDT
(In reply to Alexander Nyßen from comment #4)
> Sounds like an SWT regression...

I'd like to be able to diagnose it somehow, but my SWT Fu is not strong.
Comment 6 Phil Beauvoir CLA 2017-10-19 11:25:55 EDT
Animation is also not working on Eclipse 4.6 and Mac OS X 10.13 (High Sierra).

I'm not sure that if this is a SWT issue should I re-open bug #135352 or is this something else?

Another problem is that one can't test against the Flow example because of bug #522575
Comment 7 Matthias Wienand CLA 2017-10-19 11:42:36 EDT
Well, in order to find out if this is an SWT regression, you can try to run with an older version of SWT, and see if animations still do not work. However, GEF Legacy might be using an SWT mechanism incorrectly, which, nonetheless, used to work, but is not working anymore with a recent version of SWT. So, it might or might not be a "regression". However, determining the SWT version for which animations break is the first step in finding the root cause of the problem, IMHO.

The example wizard issue is separate from that, and is probably related to FileLocator.toFileURL(url) being unable to find the corresponding zip archive (for whatever reason).
Comment 8 Phil Beauvoir CLA 2017-10-19 11:49:50 EDT
Putting aside Eclipse 4.7 for the moment, I tested my app with the following combinations:

Eclipse 4.6.3 + OS X 10.10, 10.11, 10.12 - animation works.
Eclipse 4.6.3 + OS X 10.13 - animation does not work.

In this case, something changed in OS X 10.13, so maybe not SWT?
Comment 9 Matthias Wienand CLA 2017-10-19 11:57:38 EDT
This is indeed a good indicator that a change in OS X 10.13 is the origin of the problem. However, SWT utilises the platform API, so you could argue that it is still an SWT problem. I could imagine that a newer version of OS X also requires a newer version of SWT. So, your setup might already work when using the latest version of SWT.
Comment 10 Phil Beauvoir CLA 2017-10-19 11:59:09 EDT
> So, your setup might already work when using the latest version of SWT.

You mean OS X 10.13 and the version of SWT found in latest Eclipse 4.7? If so, I'll test.
Comment 11 Phil Beauvoir CLA 2017-10-19 12:47:16 EDT
(In reply to Phil Beauvoir from comment #10)
> > So, your setup might already work when using the latest version of SWT.
> 
> You mean OS X 10.13 and the version of SWT found in latest Eclipse 4.7? If
> so, I'll test.

Animation not working using Eclipse 4.7.1 and OS X 10.13.