Community
Participate
Working Groups
Currently the HandleDelta class (largely adapted from JDT JavaElementDelta) is way too open. Each of its more than 50 members are either public or protected. The API surface area so large (and, to make matters worse, not very clean) may hinder future evolution of this class. It would be better to err on the 'too restricted' side initially and introduce additional API when/if it is requested by adopters. I suppose it's not too late to do it now.
Pushed to master: http://git.eclipse.org/c/handly/org.eclipse.handly.git/commit/?id=03900b83982ef56684b6b6c156fceb9dfedc93db Breaking changes: A number of 'toString' methods has changed signatures: - public String toDebugString(int) -> public void toStringFull(IndentationPolicy, int, StringBuilder) - protected void toDebugString(StringBuilder) -> public void toStringMinimal(StringBuilder builder) - protected boolean toDebugString(StringBuilder, int) -> protected boolean toStringFlags(StringBuilder builder) The following previously public members has reduced visibility: - insert(HandleDelta) : private - createDeltaTree(HandleDelta) : private - addAffectedChild(HandleDelta) : private - removeAffectedChild(HandleDelta) : gone - clearAffectedChildren() : default (But overall, the public API remained largely the same) The following previously protected members remained protected: - newDelta(IHandle) - needsChildIndex() Other previously protected members are private now.
