Bug 480806 - Remove unnecessary setFocus() calls that tried to avoid overriding the default button
Summary: Remove unnecessary setFocus() calls that tried to avoid overriding the defaul...
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 471329 479727
Blocks:
  Show dependency tree
 
Reported: 2015-10-27 14:55 EDT by Markus Keller CLA
Modified: 2017-05-24 14:14 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2015-10-27 14:55:24 EDT 
Follow-up to bug 471329, bug 479727.

Remove unnecessary setFocus() calls that tried to avoid overriding the default button. Also check MessageDialog and subclasses.

Test on all platforms:
- Mac: first control/button should get focus by default
- Win/GTK: first control should get focus unless it's a push button. In that case, the default button has to get the default focus.
Comment 1 Eclipse Genie CLA 2015-10-27 14:59:44 EDT 
New Gerrit change created: https://git.eclipse.org/r/59048
Comment 2 Markus Keller CLA 2015-10-27 15:04:36 EDT 
(In reply to Eclipse Genie from comment #1)
> New Gerrit change created: https://git.eclipse.org/r/59048

This is just a first cut that fixes the problems mentioned in bug 471329. Need to check all setFocus() calls.