480773 – Manage better editor opening on Eclipse restart with failing session opening

Bug 480773 - Manage better editor opening on Eclipse restart with failing session opening

Summary: Manage better editor opening on Eclipse restart with failing session opening

Status:	CLOSED FIXED

Alias:	None

Product:	Sirius
Classification:	Modeling
Component:	Core (show other bugs)
Version:	3.0.0
Hardware:	PC Linux

Importance:	P3 enhancement (vote)
Target Milestone:	3.1.2
Assignee:	Esteban DUGUEPEROUX
QA Contact:

URL:
Whiteboard:
Keywords:	triaged

Depends on:
Blocks:

Reported:	2015-10-27 09:27 EDT by Esteban DUGUEPEROUX
Modified:	2015-11-10 08:13 EST (History)
CC List:	3 users (show)

See Also:	Gerrit Change Gerrit Change Git Commit Git Commit Gerrit Change Git Commit

Attachments
Sample project to reproduce (2.23 KB, application/zip) 2015-10-27 10:42 EDT, Esteban DUGUEPEROUX	no flags	Details
Exceptions logged on Eclipse restart. (375.64 KB, text/x-log) 2015-10-27 10:43 EDT, Esteban DUGUEPEROUX	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Esteban DUGUEPEROUX

2015-10-27 09:27:44 EDT

Currently when restarting an Eclipse with an opened editor on content which can't be accessed, an empty session is created.
This bugzilla is to improve that, by avoiding session creation and give better feedback to end-user to displaying the reason of the failing session opening in the editor.

Comment 1 Eclipse Genie

2015-10-27 09:29:17 EDT

New Gerrit change created: https://git.eclipse.org/r/59002

Comment 2 Esteban DUGUEPEROUX

2015-10-27 10:42:48 EDT

Created attachment 257546 [details]
Sample project to reproduce

Scenario to reproduce:
1. Import the attached project sample,
2. Start an Eclipse with all representations opened.
3. Close Eclipse with these opened editors.
4. Remove Modeling Project from filesystem or make it non readable.
5. Restart Eclipse => we have many exceptions and the ErrorEditorPart is displayed with a stack. We could have the standard dialect editor with a more readable message.

Comment 3 Esteban DUGUEPEROUX

2015-10-27 10:43:33 EDT

Created attachment 257547 [details]
Exceptions logged on Eclipse restart.

Comment 4 Esteban DUGUEPEROUX

2015-10-27 11:43:16 EDT

To validate replay scenario of comment 2 and restore project from filesystem before trying session reopening by project opening.

Comment 5 Eclipse Genie

2015-10-29 04:03:35 EDT

New Gerrit change created: https://git.eclipse.org/r/59193

Comment 6 Eclipse Genie

2015-11-02 02:55:35 EST

Gerrit change https://git.eclipse.org/r/59002 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=366827e38895db0dcc2f20c694a07417b5ed509e

Comment 7 Esteban DUGUEPEROUX

2015-11-02 02:56:04 EST

Fixed on master.

Comment 8 Eclipse Genie

2015-11-02 03:42:34 EST

Gerrit change https://git.eclipse.org/r/59193 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7bf70fa2cb36dc5555e36dfdd782a84a434d9783

Comment 9 Florian Barbin

2015-11-02 09:31:45 EST

Verified on Sirius 3.1.2.201511020854

Comment 10 Eclipse Genie

2015-11-02 09:35:30 EST

New Gerrit change created: https://git.eclipse.org/r/59476

Comment 11 Eclipse Genie

2015-11-02 09:56:27 EST

Gerrit change https://git.eclipse.org/r/59476 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=36ca1a9ce46db76bab32641b43303347d518ad7c

Comment 12 Pierre-Charles David

2015-11-10 08:13:10 EST

Available in Sirius 3.1.2.