Community
Participate
Working Groups
When a create a new review a likely next step is to add a reviewer. If I use EGit to create a review, it may be possible for EGerrit to figure that out and to optionally automatically open that review to allow me to add a reviewer. I wonder if there are other ways to achieve this besides integrating with EGit? Maybe Gerrit has hooks that could trigger a notification to my Eclipse when I create a review?
When a review gets pushed to the gerrit server, a link to the review is presented in the dialog confirming the completion of the push. We had planned to hook into EGit to have the link open our editor. As for opening automatically, I'm not necessary a fan of that approach since it may not work for other people. For example I know of some teams where the reviewers are automatically added (not sure if it is by jenkins or gerrit itself though).
(In reply to Pascal Rapicault from comment #1) > When a review gets pushed to the gerrit server, a link to the review is > presented in the dialog confirming the completion of the push. > We had planned to hook into EGit to have the link open our editor. I think we need to EGit help to get this done. I spoke to Mattias Sohn at EclipseCon about this and he was quite willing to add some kind of event to EGit when something is pushed to Gerrit. > As for opening automatically, I'm not necessary a fan of that approach since > it may not work for other people. For example I know of some teams where the > reviewers are automatically added (not sure if it is by jenkins or gerrit > itself though). Ah, good point. Maybe it should be an option? I'm imagining a dialogue poping up saying "Do you want EGerrit to automatically open the review after you have pushed it to Gerrit? This can help add reviewers" Yes/No _ Remember preference.
