Bug 479940 - Label Border Style options are not intuitive
Summary: Label Border Style options are not intuitive
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 3.1.0   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2015-10-16 05:37 EDT by Frédéric Madiot CLA
Modified: 2015-10-27 12:17 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Madiot CLA 2015-10-16 05:37:42 EDT 
The Label Border Style options reflect internal or legacy decisions, they should be more intuitive:
- by default the option is empty, but it has not the same behaviour wether the Container is List (border) or Free Form (no border).
- "Label Border For Container" can be selected for a List -> what does it mean ?
- "No Label Border For List" can be selected for a Free Form  -> what does it mean ?
- "Label Border Style With Beveled Corner" can be selected for a List, but it does nothing

I propose to rename these options to:
-"No label Border"
-"Label Border"
-"Label Border With Beveled Corner"

When creating a Gradient on a List, the "Label Border" could be pre-selected. And when it is created on a Free Form, the "No label Border" option could be pre-selected.
Comment 1 Maxime Porhel CLA 2015-10-19 04:01:05 EDT 
Several MM changes might be required. 

The available border styles are stored in org.eclipse.sirius.diagram/model/DiagramEnvironment.odesign

This might be transformed into an EEnum with the current available label border styles.

This configuration parameter is only available on the Gradient style: FlatContainerStyleDescription.getLabelBorderStyle(): it should also be available on other container styles (except Parrallelogram which should not exists). 

Note that the value is used to configure the figures and content pane selection, but this is not stored in the aird model. We have to see if it should.

Note that after this enhancement, this should work for Container, List and RegionContainer.


A migration is required for existing VSM and maybe aird (if we create an attribute in the styles)
Comment 2 Maxime Porhel CLA 2015-10-27 04:10:21 EDT 
Implementor will have to pay attention (simplify, enhance, correct) to AbstractDiagramElementContainerEditPart.reInitFigure(), border, margin, compartment edit part refreshes, ...