Bug 479352 - [Tooling] Introduce a 'Replication' field on Real Time tab in Properties View for a Port
Summary: [Tooling] Introduce a 'Replication' field on Real Time tab in Properties View...
Status: CLOSED FIXED
Alias: None
Product: Papyrus-rt
Classification: Modeling
Component: tool (show other bugs)
Version: 0.8.0   Edit
Hardware: PC Windows 7
: P3 normal
Target Milestone: 0.8.0   Edit
Assignee: smaoui asma CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 479350 484194 497825
  Show dependency tree
 
Reported: 2015-10-08 10:53 EDT by Peter Cigehn CLA
Modified: 2016-09-28 07:35 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Cigehn CLA 2015-10-08 10:53:21 EDT 
As discussed in Bug 473064 Comment 32 it is proposed that a port should have one field 'Replication' for setting the multiplicity of the port.

The rules for updating the 'Replication' field for a port should be that both lower bound and upper bound should be set to the same value according to the value entered in the 'Replication' field.

It should be possible to both enter integer values as well as string values, and the relevant literals should be created for lower and upper bound.
Comment 1 Peter Cigehn CLA 2015-10-08 10:54:16 EDT 
Please also see the related Bug 479350 for a replication field for a capsule part.
Comment 2 Peter Cigehn CLA 2015-11-30 09:14:26 EST 
Please see Bug 479350 Comment 2 which is also equally relevant for this Bugzilla.
Comment 3 Eclipse Genie CLA 2015-12-11 09:48:57 EST 
New Gerrit change created: https://git.eclipse.org/r/62486
Comment 4 Remi Schnekenburger CLA 2016-03-09 10:07:06 EST 
See also Bug Bug 482692: [Tooling] Optional Capsule should have hatching Pattern to update the code on that part.
Comment 5 Peter Cigehn CLA 2016-05-20 03:39:52 EDT 
Remi, I guess this one also should be assigned to Asma?
Comment 6 Eclipse Genie CLA 2016-05-26 09:55:34 EDT 
New Gerrit change created: https://git.eclipse.org/r/73726
Comment 7 Eclipse Genie CLA 2016-05-27 05:17:15 EDT 
New Gerrit change created: https://git.eclipse.org/r/73791
Comment 8 smaoui asma CLA 2016-05-27 09:00:38 EDT 
This gerrit https://git.eclipse.org/r/73726 proposes a fix for this bug as well as a factorization of the fix proposed for the Bug 479350 to not duplicate Editos/Dialogs/Properties/Observables for the Replication field added both to Port and Capsule Part.

Asma
Comment 10 Christian Damus CLA 2016-09-06 09:02:38 EDT 
(In reply to Eclipse Genie from comment #9)
> Gerrit change https://git.eclipse.org/r/73726 was merged to [master].
> Commit:
> http://git.eclipse.org/c/papyrus-rt/org.eclipse.papyrus-rt.git/commit/
> ?id=5df517db427bd8c28cf3ac97eee162fcce7e7ab1

It appears that the RCPTT test case Port_30 now fails because the property sheet UI for ports has changed, so the test can no longer find certain UI elements to interact with.  This test failure is currently blocking the Papyrus-RT product build.

The test case will need to be updated; see https://hudson.eclipse.org/papyrus-rt/job/Papyrus-RT-Gerrit-RCPTT/14/console for details.

Also, another test case affected by this new feature already has a fix in the works.  I would suggest that changes to the Port_30 test case be done in the patch set https://git.eclipse.org/r/#/c/80465/
Comment 11 Peter Cigehn CLA 2016-09-07 04:54:42 EDT 
I have checked the merged Gerrit change in the latest Papyrus-RT build. And the replication field looks good. The handling of lower and upper, i.e. they are always assigned the same value, i.e. the value in the replication field.

I will put this one into resolved/verified fixed. Any possible remaining issues will be tracked in separate Bugzillas.
Comment 12 Peter Cigehn CLA 2016-09-28 07:35:20 EDT 
Closing as verified fixed.