Bug 479219 - It is not possible to drop an element from the Interpreter view result tree.
Summary: It is not possible to drop an element from the Interpreter view result tree.
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 2.0.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 5.1.0   Edit
Assignee: Pierre-Charles David CLA
QA Contact: Julien Dupont CLA
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2015-10-07 05:18 EDT by Maxime Porhel CLA
Modified: 2017-11-08 03:37 EST (History)
2 users (show)

See Also:


Attachments
Reproduction case (1.61 KB, application/zip)
2015-10-07 05:26 EDT, Maxime Porhel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Porhel CLA 2015-10-07 05:18:54 EDT
Step to reproduce: 
 . Open the "rootpackage entities" diagram of the attached project
 . Open the "Interpreter" view and select the Sirius interpreter
 . Type the following request aql:self.target.eContents()
 . Expand p1
 . Drag and drop the class on the diagram
 . The drop is not accepted

Note that if your do the same scenario from the "Model Interpreter View", the class appears on the diagram. 


Tips: 
 . DDiagramEditorTransferDropTargetListener is created with LocalSelectionTransfer.getTransfer() as parameter
 . The ModelDragTargetadapter used in ModelRequestInterpreterView also use LocalSelectionTransfer
 . The InterpreterView result viewer has a drag support using LocalTransfer 
 . The InterpreterView result viewer has a drop support using both LocalTransfer and LocalSelectionTransfer

We should go further in the analysis to identify if the DDiagramEditorImpl (and TreeEditor and DTableEditor) might require some correction in their drop support or if a Bug needs to be created on the Acceleo side to add the LocalSelectionTransfer to the result viewer drag support.
Comment 1 Maxime Porhel CLA 2015-10-07 05:26:10 EDT
Created attachment 257098 [details]
Reproduction case
Comment 2 Eclipse Genie CLA 2017-07-26 04:55:08 EDT
New Gerrit change created: https://git.eclipse.org/r/101974
Comment 4 Eclipse Genie CLA 2017-08-28 09:51:06 EDT
New Gerrit change created: https://git.eclipse.org/r/103767
Comment 5 Pierre-Charles David CLA 2017-08-28 09:55:21 EDT
The root issue has been fixed by 4c8e8d8b90c12e57741f2059ce41d8f82d96bbf3 on the Acceleo side. https://git.eclipse.org/r/103767 makes sure Sirius consumes a recent version of Acceleo where the fix is present.
Comment 7 Pierre-Charles David CLA 2017-09-12 05:46:40 EDT
Fixed by e60a70690bb547b3eb2466eda9b7b2db3a3ba7e5 on the Sirius side, which makes sure we consume (and include in our own repo) a version of the view with the fix.
Comment 8 Pierre-Charles David CLA 2017-11-08 03:37:15 EST
Available in Sirius 5.1.0, see https://wiki.eclipse.org/Sirius/5.1.0.