Bug 478886 - "saving session" is still displayed in the workbench progress area after the end of save
Summary: "saving session" is still displayed in the workbench progress area after the ...
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Core (show other bugs)
Version: 2.0.5   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 4.0.0M6   Edit
Assignee: Project inbox CLA
QA Contact: Laurent Redor CLA
URL:
Whiteboard: backport
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2015-10-02 06:06 EDT by Laurent Fasani CLA
Modified: 2016-06-24 08:04 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Fasani CLA 2015-10-02 06:06:56 EDT 
- create a modeling project
- add en ecore model
- save -> "Saving session" is displayed in the Workbench progress area even after the end of the save.(Workbench progress area is displayed by default in the bottom right corner of eclipse)

Even if you do an action to display something else in this area (for example closing and reopening the project), "Saving session" is still displayed.
Comment 1 Maxime Porhel CLA 2015-10-05 06:02:16 EDT 
Some entry points: 
 . org.eclipse.sirius: 
   . SaveSessionJob_sessionSavingMsg
   . DAnalysisSessionImpl_saveMsg
 . org.eclipse.sirius.ui: 
   . DesignerControlAction_savingTask (not related to the current scenario)
Comment 2 Maxime Porhel CLA 2015-10-08 02:49:03 EDT 
Not reproduced with Sirius 2.0 on Luna SR2

Reproduced with Sirius 3.0 on Mars
Reproduced with Sirius 3.1 on Mars.1
Comment 3 Maxime Porhel CLA 2015-10-08 02:58:30 EDT 
Update

On Luna with Sirius 2.0.5 (ObeoDesigner 7.0.1)

I reproduced the issue but with a slightly different scenario: I expand the modeling project and I paste an ecore file in it. The modeling project is then dirty, if I save it, the "Session saving" appears and stay in the progress area.

Note that a Viewpoint selection does not make the "Session saving" disappear but corretly trigger the auto save because there is no opened editor.
Comment 4 Maxime Porhel CLA 2015-10-08 03:02:11 EDT 
Sirius 2.0.5 on Juno 3.8.2 -> same issue. 




Sometimes directly after the paste of an ecore file, othertimes after a Viewpoint selection change. 

This seems to be caused by the auto-save.
Comment 5 Esteban DUGUEPEROUX CLA 2015-12-08 11:58:58 EST 
I reproduce easily this issue by doing changes in session without opened editor, for example using Model Explorer contextual menu actions or editing properties through properties view with selection from Model Explorer.
Calling SaveSessionJob.setSystem(true) or SaveSessionJob.setUser(true) in SaveSessionWhenNoDialectEditorsListener before job scheduling have the job label disappears. Not yet analyzed why.
Comment 6 Eclipse Genie CLA 2015-12-08 12:01:25 EST 
New Gerrit change created: https://git.eclipse.org/r/62243
Comment 7 Pierre-Charles David CLA 2015-12-15 04:11:52 EST 
Moving out of the 4.0 scope for now, along with all the other issues which were there "by default". This does not mean some of these will not be re-integrated at some point, but for now these issues are not part of the roadmap for 4.0.

If you feel strongly about this removal from 4.0 and/or are ready to sponsor the corresponding work, feel free to comment.
Comment 9 Esteban DUGUEPEROUX CLA 2016-02-08 10:33:02 EST 
Gerrit merged.
Comment 10 Laurent Redor CLA 2016-05-23 11:09:39 EDT 
Verified on Sirius 4.0.0 RC1 (4.0.0.201605180923) with scenario of comment 5 (edit properties of element selected in Model Explorer view).
Comment 11 Pierre-Charles David CLA 2016-06-24 08:04:06 EDT 
Available in Sirius 4.0.0.