Bug 477750 - Thumbnail figure is offset from source figure (regression)
Summary: Thumbnail figure is offset from source figure (regression)
Status: RESOLVED FIXED
Alias: None
Product: GEF
Classification: Tools
Component: GEF-Legacy Draw2d (show other bugs)
Version: 3.10.1   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.0.0 / 3.11.0 (Neon) M2   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-17 14:55 EDT by Alexander Nyßen CLA
Modified: 2015-09-17 15:00 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Nyßen CLA 2015-09-17 14:55:36 EDT 
While fixing bug #309912 we introduced a regression to Thumbnail. That is, if the source figure contains an origin different from (0,0) (e.g. when a freeform figure contains children that are moved north-west of the origin) the thumbnail image is offset (and the top-right gets truncated). This can easily be reproduced in the logic example.

The reason is that ThumnailUpdateer#run() does not apply the x and y scale to the figure offset when translating the tile graphics.
Comment 1 Alexander Nyßen CLA 2015-09-17 15:00:28 EDT 
Fixed regression by ensuring the source figure location used to translate the tileGraphics is properly scaled. Resolving as fixed in 3.11.0 M2.