Bug 477596 - Sirius swallows diagnostic message from interpreter evaluations
Summary: Sirius swallows diagnostic message from interpreter evaluations
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.1.0   Edit
Assignee: Project inbox CLA
QA Contact:
URL:
Whiteboard: triaged
Keywords:
Depends on:
Blocks: 479726
  Show dependency tree
 
Reported: 2015-09-16 11:10 EDT by Laurent Goubet CLA
Modified: 2015-10-16 09:12 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Goubet CLA 2015-09-16 11:10:43 EDT 
org.eclipse.sirius.common.acceleo.aql.business.internal.AQLSiriusInterpreter.evaluate(EObject, String)

this method will throw an exception if the diagnostic has an ERROR severity... but it will completely throw away the children of that diagnostic, along with potential errors they may hold.
Comment 1 Laurent Goubet CLA 2015-09-16 11:11:48 EDT 
Most likely the cause for Bug 477217 , which cannot be reproduced exactly as the steps mention (though it was reproduced when using a semantic element selected in the model explorer view
Comment 2 Pierre-Charles David CLA 2015-09-28 09:01:19 EDT 
I believe this was mostly fixed by https://git.eclipse.org/r/#/c/53690/8, which introduces the new IInterpreterWithDiagnostic especially for this purpose. However the new capability was not completely exposed to client code. It should be fixed once https://git.eclipse.org/r/56849 is merged.
Comment 3 Pierre-Charles David CLA 2015-10-14 03:26:54 EDT 
Fixed by 90f4cc30054957aa8376572ed9391a02882687d1.
Comment 4 Maxime Porhel CLA 2015-10-14 05:06:38 EDT 
Validated on Sirius 3.1.0.201510130903 and AQL 4.0.0.201510121214

Note that eContents(<type> and eAllContents(<type>) works (tested on ecore and a model from garden metamodel attached on Bug 477217).


Note that Bug 479726 has been created for an issue when there is no selected Viewpoint.
Comment 5 Pierre-Charles David CLA 2015-10-16 09:12:05 EDT 
Available in Sirius 3.1.0.