Bug 476883 - [rulers][hovering] Clicking on Add/Remove breakpoint of expanded annotation hover should not activate quick fix
Summary: [rulers][hovering] Clicking on Add/Remove breakpoint of expanded annotation h...
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.5   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks: 476676
  Show dependency tree
 
Reported: 2015-09-08 09:50 EDT by Dani Megert CLA
Modified: 2022-10-13 00:46 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2015-09-08 09:50:14 EDT
4.5.

Clicking on Add/Remove breakpoint in expanded annotation hover should not activate quick fix.
Comment 1 William Riley CLA 2016-10-05 16:53:00 EDT
I fixed this for CDT when porting the expanded annotation hover over in CDT 9.1 by removing the fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=165533.

This behavior appeared to be caused by the difference in mouse events used by the ruler column and the hover as a result of that fix. The hover reacts to mouseDown then the column mouseUp.

I was planning to try to contribute all the fixes I made back to JDT, but haven't had the time yet. This bug is particularly time consuming, 165533 doesn't effect CDT but I haven't tested JDT to see if removing the fix is also possible here & Linux isn't a platform I use regularly.

The CDT port is on https://bugs.eclipse.org/bugs/show_bug.cgi?id=476797.
Comment 2 Dani Megert CLA 2016-10-06 09:16:46 EDT
(In reply to William Riley from comment #1)
> 165533 doesn't effect CDT but I haven't tested JDT to see if removing the fix is
> also possible here & Linux isn't a platform I use regularly.

In JDT we do have actions on them and they have to work.
Comment 3 William Riley CLA 2016-10-06 09:38:57 EDT
(In reply to Dani Megert from comment #2)
> (In reply to William Riley from comment #1)
> > 165533 doesn't effect CDT but I haven't tested JDT to see if removing the fix is
> > also possible here & Linux isn't a platform I use regularly.
> 
> In JDT we do have actions on them and they have to work.

Sorry I wasn't clear, I meant if the cause of 165533 has been fixed elsewhere in the platform since 3.3. If so removing the fix for 165533, as I did for CDT, is possible as it wouldn't break the actions. I'm assuming not so different fix would likely be needed.
Comment 4 Dani Megert CLA 2016-10-07 06:56:51 EDT
(In reply to William Riley from comment #3)
> (In reply to Dani Megert from comment #2)
> > (In reply to William Riley from comment #1)
> > > 165533 doesn't effect CDT but I haven't tested JDT to see if removing the fix is
> > > also possible here & Linux isn't a platform I use regularly.
> > 
> > In JDT we do have actions on them and they have to work.
> 
> Sorry I wasn't clear, I meant if the cause of 165533 has been fixed
> elsewhere in the platform since 3.3. If so removing the fix for 165533, as I
> did for CDT, is possible as it wouldn't break the actions. I'm assuming not
> so different fix would likely be needed.

Yes, if the scenario itself still works, then that's OK.
Comment 5 Eclipse Genie CLA 2020-09-25 04:43:16 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 6 Eclipse Genie CLA 2022-10-13 00:46:15 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.