Bug 476654 - Commit viewer doesn't show message for commit with many files
Summary: Commit viewer doesn't show message for commit with many files
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 4.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-04 10:30 EDT by Markus Keller CLA
Modified: 2015-09-10 15:38 EDT (History)
1 user (show)

See Also:


Attachments
Screenshot (45.46 KB, image/png)
2015-09-10 08:39 EDT, Markus Keller CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2015-09-04 10:30:26 EDT
4.0.2.201508222313

Try to open commit e6e341f3e6b90dd219ef8cec5c1b77f4b19c0e6c from git://git.eclipse.org/gitroot/platform/eclipse.platform.ui.git in the EGit commit viewer. The commit touches 4980 files.

The viewer shows various layout problems:

- The "Message" section is invisible. I could only make it appear by collapsing the "Files" section.

When I collapse both sections and then expand "Files" first, then "Message" stays visible. When I expand "Message" as well, it disappears again.

- Both the editor and the "Files" section show huge scroll bars. I would not expect scrollbars on the whole editor (or at least only when the editor height is very small).
Comment 1 Thomas Wolf CLA 2015-09-10 01:35:38 EDT
Cannot reproduce with EGit 4.1.0.201508210901 nor with current head. On the stable-4.0 branch, I see only 4 commits since June 24, two of which should be in your 201508222313 version.[1] Neither has got anything to do with the commit viewer. So I'm inclined to think that whatever causes the effects you're seeing is not related to EGit.

[1] https://git.eclipse.org/c/egit/egit.git/log/?h=stable-4.0
Comment 2 Thomas Wolf CLA 2015-09-10 01:38:32 EDT
Re: "not related to EGit" ... or has been fixed on master since then, of course.
Comment 3 Markus Keller CLA 2015-09-10 08:39:09 EDT
Created attachment 256489 [details]
Screenshot

On Eclipse SDK I20150908-0800, I'm now running on EGit 4.1.0.201509071148, which I got from http://download.eclipse.org/egit/updates-nightly

I still see the problem, see screenshot.

Also reproduced the same on Linux GTK3, Ubuntu 12.04 on I20150901-0800 with EGit 3.6.2.201501210735-r
Comment 4 Thomas Wolf CLA 2015-09-10 15:38:06 EDT
(In reply to Markus Keller from comment #3)
> On Eclipse SDK I20150908-0800, I'm now running on EGit 4.1.0.201509071148,
> which I got from http://download.eclipse.org/egit/updates-nightly

Took me more time than expected to get that Eclipse SDK up and running. I20150908-0800 won't run on JDK 7 on my Mac OS X 10.7.5... had to (finally) install a JDK 8. Luckily, that seems to work, although Oracle claims one needed 10.8 at least.

Anyway: installed EGit nightly (4.1.0.201509101201 is what I got -- didn't see anything to get the precise same version as you had) and tried again.

I still cannot reproduce this problem on my machine. (Mac OS X 10.7.5, JDK 1.8) Commit Viewer works flawlessly for me with commit e6e341f3 from eclipse.platform.ui.

$ java -version
java version "1.8.0_60"
Java(TM) SE Runtime Environment (build 1.8.0_60-b27)
Java HotSpot(TM) 64-Bit Server VM (build 25.60-b23, mixed mode)
$ 

Maybe OS-related?