Bug 476617 - SourceFileDocumentProvider overhaul
Summary: SourceFileDocumentProvider overhaul
Status: RESOLVED FIXED
Alias: None
Product: Handly
Classification: Technology
Component: UI (show other bugs)
Version: 0.4   Edit
Hardware: All All
: P3 enhancement
Target Milestone: 0.4   Edit
Assignee: Vladimir Piskarev CLA
QA Contact:
URL:
Whiteboard: breakingchange
Keywords: api
Depends on:
Blocks:
 
Reported: 2015-09-04 04:20 EDT by Vladimir Piskarev CLA
Modified: 2015-09-07 04:00 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Piskarev CLA 2015-09-04 04:20:16 EDT 
SourceFileDocumentProvider API needs an overhaul:

* Introduce a new method getWorkingCopyInfoFactory that returns IWorkingCopyInfoFactory

* Rename the method createWorkingCopyReconciler to getWorkingCopyReconciler (breaking change)

* Rename the static class WorkingCopyInfo to SourceFileInfo (breaking change)
Comment 1 Vladimir Piskarev CLA 2015-09-07 04:00:53 EDT 
Pushed to master:
http://git.eclipse.org/c/handly/org.eclipse.handly.git/commit/?id=3751ff67c1cfebbfc241aef7e70319ae8e8a7c7c

Breaking changes in addition to those mentioned in the original description:

* Changed the order of arguments in the SourceFileDocumentProvider two-arg constructor

* Reduced visibility of the SourceFileInfo#workingCopy field to package-private