Bug 476570 - Custom Style Border nodes do not work with Edge creation tools
Summary: Custom Style Border nodes do not work with Edge creation tools
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 2.0.5   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 2.0.7   Edit
Assignee: Maxime Porhel CLA
QA Contact: Laurent Redor CLA
URL:
Whiteboard:
Keywords: triaged
Depends on: 476114 476572
Blocks: 476569
  Show dependency tree
 
Reported: 2015-09-03 10:40 EDT by Maxime Porhel CLA
Modified: 2017-01-31 08:49 EST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Porhel CLA 2015-09-03 10:40:29 EDT
+++ This bug was initially created as a clone of Bug #476114 +++

We create a border node that has a custom style supplied by a custom editpart with our own shape.  We also create a editPartProvider that provides our shape.  
We have a creation tool that connects these border nodes together.

If we use Sirius defined shapes as our Style the Connection Tool works just fine.  If we, however, use our custom style border node the connection tool does not work.

Supplied are a version of the basic family model from the example that illustrates the problem.  I define a basic custom style that is a simple square shape and try to use the connection tool with it and it fails to recognize that it is a valid connection point.  

The BasicFamilyModelWithCustomEditPart.zip contains the model code and the custom edit part.

The ModedAndDesign contains the model and the odesign file.

Import projects from the BasicFamilyModelWithCustomEditPart.zip and run a eclipse application.

Import the ModelAndDesign.zip into the running eclipse.

open a diagram and try to connection the border nodes to each other with the custom style active. It will not allow it.

modify the odesign file and set the ConditionalStyle expression to self = null to allow the sirius defined shape style to be selected and try the connection again.  It should be allowed this time.

Thanks,
Comment 1 Eclipse Genie CLA 2015-09-03 11:00:14 EDT
New Gerrit change created: https://git.eclipse.org/r/55216
Comment 3 Maxime Porhel CLA 2015-09-03 11:01:17 EDT
Documentation has been modified on v2.0.x branch
Comment 4 Laurent Redor CLA 2017-01-04 03:25:58 EST
Validated with Sirius 2.0.7 (2.0.7.201611241521)
Comment 5 Pierre-Charles David CLA 2017-01-31 08:49:41 EST
Available in Sirius 2.0.7, see https://wiki.eclipse.org/Sirius/2.0.7.