Bug 476523 - Add variables in precondition for reconnection tool
Summary: Add variables in precondition for reconnection tool
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: 7.0.2   Edit
Assignee: Laurent Redor CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks: 525257 573357
  Show dependency tree
 
Reported: 2015-09-03 05:09 EDT by Jean-Francois Brazeau CLA
Modified: 2022-08-04 03:18 EDT (History)
3 users (show)

See Also:

Attachments
Bug476523.zip (9.37 KB, application/x-zip-compressed)
2022-07-01 10:35 EDT, Laurent Redor CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Francois Brazeau CLA 2015-09-03 05:09:19 EDT 

    


    


      



        
          Comment 1
        

        
          Jean-Francois Brazeau CLA

        

        
        

        
          2015-09-03 05:09:34 EDT
        

      






It could be nice to have otherEnd and edgeView variable for reconnect tool precondition.

    


    


      



        
          Comment 2
        

        
          Maxime Porhel CLA

        

        
        

        
          2015-09-03 06:09:24 EDT
        

      






Implementer will have to create the homologation use case (reuse the test case)

org.eclipse.sirius.tests.unit.api.tools.ReconnectionTest can be modified to contains new tests or asserts to check that the new variables are available. The VSM of the test might simply be modified to check the new variables.

    


    


      



        
          Comment 3
        

        
          Eclipse Genie CLA

        

        
        

        
          2015-09-03 06:09:56 EDT
        

      






New Gerrit change created: https://git.eclipse.org/r/55181

    


    


      



        
          Comment 4
        

        
          Laurent Redor CLA

        

        
        

        
          2022-06-27 04:41:47 EDT
        

      






This issue is also linked to bug 573357.

    


    


      



        
          Comment 5
        

        
          Eclipse Genie CLA

        

        
        

        
          2022-06-28 12:36:52 EDT
        

      






New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/194430

    


    


      



        
          Comment 6
        

        
          Laurent Redor CLA

        

        
        

        
          2022-07-01 10:35:08 EDT
        

      






Steps to validate:
* Import project Bug476523 from "Bug476523.zip". This project contains a precondition on the target reconnect tool based on the name of source ("otherEnd" variable).
* Open diagram "new DiagramForBug467663"
* Reconnect the edge, between ref2 and EClass1, from EClass1 to EClass2
* Expected: The reconnect is OK.
* Reconnect the edge, between ref2 and EClass2, from EClass2 to EClassKO
* Expected: The reconnect is OK.
* Reconnect the edge, between ref1 and EClass1, from EClass1 to EClass2
* Expected: The reconnect is OK.
* Reconnect the edge, between ref1 and EClass2, from EClass2 to EClassKO
* Expected: The reconnect is not possible. The precondition uses the "otherEnd" variable.

    


    


      



        
          Comment 7
        

        
          Laurent Redor CLA

        

        
        

        
          2022-07-01 10:35:20 EDT
        

      






Created attachment 288615 [details]
Bug476523.zip

    


    

    

    


      



        
          Comment 10
        

        
          Laurent Redor CLA

        

        
        

        
          2022-07-06 11:13:57 EDT
        

      






The linked issue bug 573357 has not been totally fixed. The gerrit https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/194519, concerning the variables clean up, has not been fixed. Indeed, there is a regression risk with this "clean up", so it will be merged in another version.

    


    


      



        
          Comment 11
        

        
          Laurent Redor CLA

        

        
        

        
          2022-07-06 11:20:32 EDT
        

      






(In reply to Laurent Redor from comment #10)
> The linked issue bug 573357 has not been totally fixed. The gerrit
> https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/194519, concerning
> the variables clean up, has not been fixed. Indeed, there is a regression
> risk with this "clean up", so it will be merged in another version.

But this in no way prevents the variables from working properly in the context of the precondition.

    


    


      



        
          Comment 12
        

        
          Pierre-Charles David CLA

        

        
        

        
          2022-08-04 03:18:11 EDT
        

      






Available in Sirius 7.0.2: https://projects.eclipse.org/projects/modeling.sirius/releases/7.0.2