Bug 475929 - Introduce forceAdd parameter into Handle#openWhenClosed
Summary: Introduce forceAdd parameter into Handle#openWhenClosed
Status: RESOLVED FIXED
Alias: None
Product: Handly
Classification: Technology
Component: Core (show other bugs)
Version: 0.4   Edit
Hardware: All All
: P3 enhancement
Target Milestone: 0.4   Edit
Assignee: Vladimir Piskarev CLA
QA Contact:
URL:
Whiteboard: breakingchange
Keywords: api
Depends on:
Blocks:
 
Reported: 2015-08-26 10:12 EDT by Vladimir Piskarev CLA
Modified: 2015-11-03 01:53 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Piskarev CLA 2015-08-26 10:12:04 EDT 
In JDT, JavaElement#openWhenClosed has a forceAdd parameter, which is propagated to JavaModelManager#putInfos. We should probably do likewise. See bug 372687 for the reason why JDT introduced this parameter.
Comment 1 Vladimir Piskarev CLA 2015-09-11 05:41:43 EDT 
Pushed to master:
http://git.eclipse.org/c/handly/org.eclipse.handly.git/commit/?id=d1c740d32e75849ae202ea351fdf613554c4c908

Breaking changes:

* Renamed Handle#openWhenClosed to #open, and added the 'force' parameter

* Added IBodyCache#putAll method
Comment 2 Vladimir Piskarev CLA 2015-10-28 06:18:43 EDT 
> * Added IBodyCache#putAll method

Bug 477157 describes why.
Comment 3 Vladimir Piskarev CLA 2015-11-03 01:53:47 EST 
Pushed to master:
http://git.eclipse.org/c/handly/org.eclipse.handly.git/commit/?id=867a3ead70ec04cb4396d05e73af954c08d7d341

Reduced visibility of the Handle#open method to default (package-private).