Comment 1 Thibault Le Ouay 2015-08-20 10:05:16 EDT

Hey, 

I have started working on an oomph setup model but i encoure couple of issue 

1) In org.eclipse.rap.fileupload/ we need org.apache.commons.fileupload version = 1.3.1 but in the orbit repository  [1] i use there is only version 1.2.2 avaible, 

2) Where should the setup file commit ? Should I create a new project and post it to git.rap/releng ?  


Best,

Thibault


[1] http://download.eclipse.org/tools/orbit/downloads/drops/M20150819180924/?d

Comment 2 Markus Knauer 2015-08-20 10:33:43 EDT

That's great!

(In reply to Thibault Le Ouay from comment #1)
> 1) In org.eclipse.rap.fileupload/ we need org.apache.commons.fileupload
> version = 1.3.1 but in the orbit repository  [1] i use there is only version
> 1.2.2 avaible, 

Good point! We should move this library to Orbit soon. At the moment it is taken from the p2 repository at http://build.eclipse.org/rt/rap/base-platforms/3.1/extra-dependencies/

> 2) Where should the setup file commit ? Should I create a new project and
> post it to git.rap/releng ?  

Gerrit would be the best place (see [1] for further information).

Right now I'd say that it is overkill to create a new project for a single file. My suggestion would be to create a new directory below .../releng/org.eclipse.rap.build/... and put it there. Other suggestions?


[1] https://wiki.eclipse.org/RAP/Git

Comment 3 Thibault Le Ouay 2015-08-21 16:36:08 EDT

(In reply to Markus Knauer from comment #2)
> That's great!
> 
> (In reply to Thibault Le Ouay from comment #1)
> > 1) In org.eclipse.rap.fileupload/ we need org.apache.commons.fileupload
> > version = 1.3.1 but in the orbit repository  [1] i use there is only version
> > 1.2.2 avaible, 
> 
> Good point! We should move this library to Orbit soon. At the moment it is
> taken from the p2 repository at
> http://build.eclipse.org/rt/rap/base-platforms/3.1/extra-dependencies/

Ok It should be move to gerrit soon, currently i have setup my own features update site containing the needed plugins [1]
 
> > 2) Where should the setup file commit ? Should I create a new project and
> > post it to git.rap/releng ?  
> 
> Gerrit would be the best place (see [1] for further information).
> 
> Right now I'd say that it is overkill to create a new project for a single
> file. My suggestion would be to create a new directory below
> .../releng/org.eclipse.rap.build/... and put it there. Other suggestions?
> 
> 
> [1] https://wiki.eclipse.org/RAP/Git

Yep i meant gerrit but i was wondering about the location.

My setup file is working, though it's still "experimental" and not optimal however it import everything but i have issue (import cannot be resolved) for : 

org.eclipse.ui.dynamic.code
org.eclipse.rap.rwt.cluster.testfixture*

I will try to fix it over the week end
 
[1] http://thibaultleouay.github.io/

Comment 4 Eclipse Genie 2015-08-21 16:38:12 EDT

New Gerrit change created: https://git.eclipse.org/r/54341

Comment 5 Thibault Le Ouay 2015-08-21 17:53:28 EDT

Patch 2 contains few improvement 

I still need to improve my update site to add tomcat in it for : 


org.eclipse.rap.rwt.cluster.testfixture*