Bug 474878 - Improve the integration of AQL in the interpreter
Summary: Improve the integration of AQL in the interpreter
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Core (show other bugs)
Version: 3.0.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.1.0   Edit
Assignee: Stephane Begaudeau CLA
QA Contact: Maxime Porhel CLA
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks: 470460
  Show dependency tree
 
Reported: 2015-08-13 05:42 EDT by Stephane Begaudeau CLA
Modified: 2015-10-16 09:11 EDT (History)
3 users (show)

See Also:


Attachments
Screenshot (321.55 KB, image/png)
2015-08-13 05:47 EDT, Stephane Begaudeau CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stephane Begaudeau CLA 2015-08-13 05:42:16 EDT
1 - If an AQL expression has a warning, nothing is displayed (if something crashes it is displayed, everything else is considered ok).
2 - If an AQL expression returns a collection, we display its real Java type (ArrayList for example) that's an implementation detail.
3 - If the result of an evaluation is an EObject, we display the name of its java Class (again, an implementation detail) not the qualified name of its type.
4 - Pretty much everything in AQL is represented using a diagnostic with children so we need to be able to create MultiStatus object to represents all the error s or warnings found.

For the problems 1 and 3, see that SiriusEvaluationTask.createResultStatus(Object) can only create OK status not WARNING or ERROR ones (an error can only be triggered by AQL throwing an exception). In AQLSiriusInterpreter, we have all the relevant pieces of information to display a proper warning or error message and we discard them to give the result to SiriusEvaluationTask.
Comment 1 Eclipse Genie CLA 2015-08-13 05:46:54 EDT
New Gerrit change created: https://git.eclipse.org/r/53690
Comment 2 Stephane Begaudeau CLA 2015-08-13 05:47:56 EDT
Created attachment 255837 [details]
Screenshot

I have attached a screenshot of the result of the review
Comment 4 Pierre-Charles David CLA 2015-08-31 09:59:56 EDT
Fixed by 0c1dbd65678f5400049aa0390975942b86163080.
Comment 5 Eclipse Genie CLA 2015-09-28 08:45:38 EDT
New Gerrit change created: https://git.eclipse.org/r/56849
Comment 7 Maxime Porhel CLA 2015-10-14 10:02:03 EDT
Validated on Sirius 3.1.0.201510130903
Comment 8 Pierre-Charles David CLA 2015-10-16 09:11:40 EDT
Available in Sirius 3.1.0.