Community
Participate
Working Groups
1 - If an AQL expression has a warning, nothing is displayed (if something crashes it is displayed, everything else is considered ok). 2 - If an AQL expression returns a collection, we display its real Java type (ArrayList for example) that's an implementation detail. 3 - If the result of an evaluation is an EObject, we display the name of its java Class (again, an implementation detail) not the qualified name of its type. 4 - Pretty much everything in AQL is represented using a diagnostic with children so we need to be able to create MultiStatus object to represents all the error s or warnings found. For the problems 1 and 3, see that SiriusEvaluationTask.createResultStatus(Object) can only create OK status not WARNING or ERROR ones (an error can only be triggered by AQL throwing an exception). In AQLSiriusInterpreter, we have all the relevant pieces of information to display a proper warning or error message and we discard them to give the result to SiriusEvaluationTask.
New Gerrit change created: https://git.eclipse.org/r/53690
Created attachment 255837 [details] Screenshot I have attached a screenshot of the result of the review
Gerrit change https://git.eclipse.org/r/53690 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0c1dbd65678f5400049aa0390975942b86163080
Fixed by 0c1dbd65678f5400049aa0390975942b86163080.
New Gerrit change created: https://git.eclipse.org/r/56849
Gerrit change https://git.eclipse.org/r/56849 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=90f4cc30054957aa8376572ed9391a02882687d1
Validated on Sirius 3.1.0.201510130903
Available in Sirius 3.1.0.