Bug 474482 - [Capsule Diagram] Capsule representation should be synchronized by default.
Summary: [Capsule Diagram] Capsule representation should be synchronized by default.
Status: CLOSED FIXED
Alias: None
Product: Papyrus-rt
Classification: Modeling
Component: tool (show other bugs)
Version: 0.8.0   Edit
Hardware: All All
: P3 normal
Target Milestone: 0.8.0   Edit
Assignee: Celine Janssens CLA
QA Contact: Remi Schnekenburger CLA
URL:
Whiteboard:
Keywords:
Depends on: 474382 474489
Blocks: 477953
  Show dependency tree
 
Reported: 2015-08-07 05:19 EDT by Remi Schnekenburger CLA
Modified: 2016-09-28 14:46 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Remi Schnekenburger CLA 2015-08-07 05:19:38 EDT
When creating automatically the capsule diagram for a capsule, the diagram representation should be set to canonical by default. That means that a CSS should be added to the capsule viewpoint, with the canonical properties set to the capsule, the capsule compartment and the capsule parts, for external ports.
Comment 1 Celine Janssens CLA 2015-09-10 11:06:46 EDT
The technical issue I have in regards of this evolution is that when a Port is synchronized with the model, the Behavior EditPart is not displayed anymore...

I'm investigating...
Comment 2 Peter Cigehn CLA 2015-09-11 03:09:51 EDT
(In reply to Celine Janssens from comment #1)
> The technical issue I have in regards of this evolution is that when a Port
> is synchronized with the model, the Behavior EditPart is not displayed
> anymore...
> 
> I'm investigating...

I guess that this issue should be synchronized with the ongoing work in Bug 474382 which is about replacing the separate shape with a decoration on the port. Please check with Anatoliy Tischenko on the progress of this work and how it possibly could be related to technical issue you are seeing.
Comment 3 Celine Janssens CLA 2015-09-11 03:44:55 EDT
Thank you for this observation...I will wait until this bug is resolved before checking the Port Synchronization :)
Comment 5 Celine Janssens CLA 2015-09-18 10:21:11 EDT
As I checked the impact of the fix related to Bug 474382, it seems the behavior doens't disappear when canonical mode is on. 

Then I push this waiting for the rebase of the associated zvolution on Papyrus maintenance 1.1.0 Branch. 


Best regards
Comment 7 Peter Cigehn CLA 2015-11-24 10:39:20 EST
I've tested this a bit in the latest Papyrus-RT build. I am not fully sure how to test all cases, but it seem to be working. You can add ports and capsule parts from the model explorer and they automatically is shown in the capsule structure diagram. Alse the case when adding a port on capsule which is used to type a capsule part works. The port automatically appears on the capsule part (including the case when you have multiple capsule parts typed by the same capsule).

The only comment I have is that the auto layout can be improved. If you add two ports from the model explorer, then they both appear on top of each other in the top left corner of the capsule (the same also on capsule parts). So an improved auto layout that avoids putting ports on top of each other would be good. For the specific case of capsule parts there is a separate Bug 482599 related to how the positions of the ports on the capsule part shall be positioned.
Comment 8 Peter Cigehn CLA 2015-11-24 10:52:12 EST
I wrote a separate bug for the auto layout, mainly related to ports, Bug 482920. I suggest that we put this one into resolved/verified fixed, and we track the remaining auto layout in Bug 482920 and Bug 482599.
Comment 9 Remi Schnekenburger CLA 2015-11-24 11:33:14 EST
(In reply to Peter Cigehn from comment #8)
> I wrote a separate bug for the auto layout, mainly related to ports, Bug
> 482920. I suggest that we put this one into resolved/verified fixed, and we
> track the remaining auto layout in Bug 482920 and Bug 482599.

Agreed. Closing this bug.
Comment 10 Charles Rivet CLA 2016-09-28 14:46:51 EDT
Moving to closed as per comment 9