Bug 474353 - Enhance node.js implementation of our git pages using http://www.nodegit.org/
Summary: Enhance node.js implementation of our git pages using http://www.nodegit.org/
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Node (show other bugs)
Version: 10.0   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on: 479688 479698 479702 482063 482723
Blocks:
  Show dependency tree
 
Reported: 2015-08-05 15:07 EDT by Paul Webster CLA
Modified: 2016-03-30 22:59 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2015-08-05 15:07:02 EDT
Continue the work done in Bug 458883

Some of the areas that still need work:

The REFERENCE:  field say master => origin/master [New branch], but it's the default master tracking configuration and should just say master => origin/master.

All of the commits are listed in the "Outgoing" section instead of in the "History" section.  This is possibly related to the same data that's allowing [New Branch] to show up.


If I go to REFERNCES: and expand them, go to local>master and try and checkout I get "Problem while performing the action".  If I select all of my changed files and try the "checkout selected files, discarding all changes" which looks like a trash can, I get the same error message.  Looks like I can't get rid of modified files.

When I expand REFERENCES and go to origin node_git_pages there are no icons on that line that would allow me to check out that branch.  The usual behaviour is checking out a branch like origin/node_git_pages should create the local, so you end up with node_git_pages => origin/node_git_pages.
Comment 1 Mark Macdonald CLA 2015-08-05 16:42:39 EDT
A few more issues I ran into:

* Cloning a repo over ssh: or git: protocols does not seem to work. An error is logged to the server console.

* When I click a commit in the OUTGOING section, it is supposed to show the details in the right-hand pane. This isn't working, I think because the commit object in the response has an empty "Diffs" field.

* Commit log shows "More commits" link even when the end has been reached.

* (Uncertain, needs investigation) From looking at the code, I think that responses are hardcoded to begin with /gitapi. When Orion is running behind a path prefix (say /myblog/orion/gitapi) the URLs will be incorrect, they need to be generated based on the path prefix given in the incoming request.
Comment 2 Silenio Quarti CLA 2016-03-30 22:59:11 EDT
Fixed in latest