Bug 473538 - Allow to hide "Fetch", "Pull" and "Push" was successful dialog
Summary: Allow to hide "Fetch", "Pull" and "Push" was successful dialog
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted, usability
: 473824 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-07-24 14:47 EDT by Lars Vogel CLA
Modified: 2022-02-16 03:14 EST (History)
10 users (show)

See Also:

Attachments
Screenshot of dialog which breaks my workflow (343.92 KB, image/png)
2019-06-17 06:55 EDT, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2015-07-24 14:47:25 EDT 
I would like to have the option to hide the "Fetch was successful" dialog via the preferences.
Comment 1 Andrey Loskutov CLA 2015-07-24 14:52:09 EDT 
+1. 
Preferences->Team->Git->Confirmations and Warnings->

new group: "Show Dialog on Success"
with:
 [x] Fetch
 [x] Pull
 [x] Push
Comment 2 Eclipse Genie CLA 2015-07-24 16:16:55 EDT 
New Gerrit change created: https://git.eclipse.org/r/52524
Comment 3 Andrey Loskutov CLA 2015-07-29 07:40:26 EDT 
*** Bug 473824 has been marked as a duplicate of this bug. ***
Comment 4 Eclipse Genie CLA 2016-07-21 16:33:27 EDT 
New Gerrit change created: https://git.eclipse.org/r/77727
Comment 5 Matthias Sohn CLA 2017-01-08 18:03:45 EST 
(In reply to Andrey Loskutov from comment #1)
> +1. 
> Preferences->Team->Git->Confirmations and Warnings->
> 
> new group: "Show Dialog on Success"
> with:
>  [x] Fetch
>  [x] Pull
>  [x] Push

https://git.eclipse.org/r/#/c/88222/ added these preferences for fetch and push

the preference for pull is not yet implemented
Comment 6 Lars Vogel CLA 2019-06-17 06:55:07 EDT 
Created attachment 278967 [details]
Screenshot of dialog which breaks my workflow
Comment 7 Lars Vogel CLA 2019-06-17 06:55:27 EDT 
I do a lot of pushes today, and my estimate is that I have seen and close this popup today around ~40 times.

Please add option to hide this dialog in case of a successful push.
Comment 8 Thomas Wolf CLA 2019-06-17 07:03:19 EDT 
Did you read comment 5? Preferences->Git->Confirmations and Warnings, uncheck "Fetch Result Dialog" and "Push Result Dialog". The only reason this bug isn't closed is that there's no such option for the "Pull Result Dialog".
Comment 9 Lars Vogel CLA 2019-06-17 07:08:04 EDT 
(In reply to Thomas Wolf from comment #8)
> Did you read comment 5? Preferences->Git->Confirmations and Warnings,
> uncheck "Fetch Result Dialog" and "Push Result Dialog". 

Is this the same as the request? 

In case of an error I think we should always show an dialog. The preference seem to 
hide is always. If that is not the case please rename the preference label.

Also I would expect a "Do not show again" flag as on the other dialogs for consistency. Why should the user check the preference if the other dialogs have such a flag?
Comment 10 Lars Vogel CLA 2019-06-21 05:20:46 EDT 
(In reply to Lars Vogel from comment #9)
> (In reply to Thomas Wolf from comment #8)
> > Did you read comment 5? Preferences->Git->Confirmations and Warnings,
> > uncheck "Fetch Result Dialog" and "Push Result Dialog". 
> 
> Is this the same as the request? 

Thomas, WDYT?
Comment 11 Lars Vogel CLA 2022-02-16 03:14:52 EST 
Maybe the platform notification API could be used to show fetches without any update.