Bug 473107 - [TERMINALS] Show-In menu type depends on project type
Summary: [TERMINALS] Show-In menu type depends on project type
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: terminal (show other bugs)
Version: Next   Edit
Hardware: PC All
: P3 normal with 4 votes (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
: 467048 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-07-20 15:24 EDT by Paul Verest CLA
Modified: 2021-06-18 16:05 EDT (History)
7 users (show)

See Also:


Attachments
Screenshot of Package Explorer not exposing Show In -> Terminal (234.82 KB, image/png)
2021-06-17 08:22 EDT, Konrad Windszus CLA
no flags Details
Screenshot of package explorer not showing Show In -> Terminal (347.87 KB, image/png)
2021-06-17 08:24 EDT, Konrad Windszus CLA
no flags Details
show in terminal appears (36.17 KB, image/png)
2021-06-17 11:38 EDT, Jonah Graham CLA
no flags Details
macos screenshot showing the expected menu item (47.57 KB, image/png)
2021-06-18 16:05 EDT, Jonah Graham CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Verest CLA 2015-07-20 15:24:55 EDT
I just checked latest       TM Terminal	4.0.0.201506040610	org.eclipse.tm.terminal.feature.feature.group	Eclipse.org - Target Management

1. custom Show-In is not available in Package Explorer (OK, hopefully Package Explorer will be deprecated in next N 4.6)

2. in Package Explorer
for General project - only custom Show-In 
for Nodejs project (with JSDT nature) - custom and standard Show-In 
for Java project - only standard Show-In 
(Why does project type matter?)
Comment 1 Paul Verest CLA 2015-07-20 15:36:03 EDT
missed, it is Project Explorer

2. in Project Explorer
for General project - only custom Show-In 
for Nodejs project (with JSDT nature) - custom and standard Show-In 
for Java project - only standard Show-In 
(Why does project type matter?)
Comment 2 Uwe Stieber CLA 2015-07-21 03:35:26 EDT
We explicitly avoid to contribute the custom Show-In sub menu to Java projects as we found it confusing if you have 2 "Show in >" sub menus in the context menu. That's why we are looking for different approaches to have a hopefully better solution for all project types.
Comment 3 Paul Verest CLA 2015-07-21 07:11:52 EDT
(In reply to Uwe Stieber from comment #2)
> We explicitly avoid to contribute the custom Show-In sub menu to Java
> projects as we found it confusing if you have 2 "Show in >" sub menus in the
> context menu. That's why we are looking for different approaches to have a
> hopefully better solution for all project types.

custom Show-In has been confusing. Why not just call it Terminal ?
Comment 4 Uwe Stieber CLA 2015-07-21 07:33:56 EDT
(In reply to Paul Verest from comment #3)
> custom Show-In has been confusing. Why not just call it Terminal ?

Well, could be an option.
Comment 5 Dirk Fauth CLA 2015-12-28 16:24:34 EST
I really like this plug-in and the option to configure other shells like the Git bash. The Show-In issue for Java projects is really confusing. 

Why don't you contribute to the default Show-in menu for Java projects? Wouldn't that be an option?
Comment 6 Eclipse Genie CLA 2016-02-10 15:11:22 EST
New Gerrit change created: https://git.eclipse.org/r/66342
Comment 7 Martin Oberhuber CLA 2016-02-16 06:01:30 EST
Many thanks for the contribution ! - We'll have a look soon.
Comment 9 Martin Oberhuber CLA 2016-03-12 02:37:46 EST
So here's the status quo with Dirk's contribution (many thanks!):

- Git Perspective Working Tree:
  .1 Show In (Alt+Shift+W) > Terminal
- C/C++ Perspective:
  .2 C Project   : Show in Local Terminal > Git Bash
  .3 Java Project: Show in Local Terminal > Git Bash || Show In > no Terminal!
- Java Perspective - Package Explorer, any project (tested C and Java):
  .4 Show In (Alt+Shift+W) > Terminal
- Java Perspective - Project Explorer
  .5 Java Project: Show in Local Terminal > Git Bash || Show In > Terminal
  .6 C Project   : Show in Local Terminal > Git Bash


I think it's better than what we used to have, since the Terminal is now discoverable through the context menu by "some" way in all cases (I couldn't test Node projects). It is unfortunate that it's not consistent but I'm not sure if we could do anything about that and I personally don't really care too much since I prefer using Ctrl+Alt+T rather than deep context menus.

It's sad that in the Git Perspective Working Tree we don't have a way to open Git Bash from the context menu; that could probably be resolved by the enhancement request to improve changing the default shell,
https://bugs.eclipse.org/bugs/show_bug.cgi?id=489475 -- would open the selection dialog to allow choosing Git Bash when started the first time.

Or should we just have the "Show in Local Terminal > Git Bash" contributed to Git Perspective? - Then this menu would be available everywhere except Package Explorer (which we agreed we don't care). Only downside is having two different "Show In" menus in some cases.

Paul what do you think ?
Comment 10 Martin Oberhuber CLA 2016-03-12 03:09:45 EST
Actually on Linux, Neon M5, C/C++ Perspective, Java Project I get *no*
"Show in Local Terminal" context menu and *no* Show In > Local Terminal.
So here is at least one case where the Terminal is not yet discoverable...
Comment 11 Jonah Graham CLA 2020-05-01 10:08:38 EDT
The Terminal component of the Eclipse Ecosystem has a new home. The Terminal is now part of the Eclipse CDT project[1].

This change means a new Git repo[2], P2 site[3] and Bugzilla component. The terminal will continue to be delivered as part of the quarterly Simultaneous Release of Eclipse as well.

The marketplace entry[4] had not been updated in a few years. It will once again install the latest release of the terminal on the latest release of the whole IDE (currently 2020-03).

If this bug is no longer relevant, please feel free to comment or close the bug. If you can confirm if this issues still occurs in the latest release please do let me know in a comment.

[1] https://wiki.eclipse.org/CDT/User/NewIn911
[2] https://git.eclipse.org/c/cdt/org.eclipse.cdt.git (in the terminal directory)
[3] current release is 9.11 - P2 site https://download.eclipse.org/tools/cdt/releases/9.11/
[4] https://marketplace.eclipse.org/content/tm-terminal

(This comment was added to all open terminal bugs along with changing the Product/component pair to CDT/terminal.)
Comment 12 Jonah Graham CLA 2020-05-01 17:08:44 EDT
*** Bug 467048 has been marked as a duplicate of this bug. ***
Comment 13 Konrad Windszus CLA 2021-06-17 08:03:27 EDT
With Eclipse 2021-03 and 2021-06 in the Java Perspective the package explorer does no longer expose "Show in" -> "Terminal" for all project of nature "Java" in case no external terminal command was configured. This is really confusing as now it is no longer possible to open the default terminal at all in that view.

In Java EE Perspective in the Project Explorer the "Show In" still exposes "Terminal"
Comment 14 Konrad Windszus CLA 2021-06-17 08:22:20 EDT
Created attachment 286610 [details]
Screenshot of Package Explorer not exposing Show In -> Terminal
Comment 15 Konrad Windszus CLA 2021-06-17 08:24:48 EDT
Created attachment 286611 [details]
Screenshot of package explorer not showing Show In -> Terminal
Comment 16 Jonah Graham CLA 2021-06-17 11:13:38 EDT
Hi Konrad, Thanks for updating this bug report. For me the Show In -> Terminal does appear for Java projects, so there must be some larger configuration issue involved. I would be grateful if you could confirm which package you are using, and what extra plug-ins you may have installed? Also, which platform are you on?
Comment 17 Konrad Windszus CLA 2021-06-17 11:18:25 EDT
You can reproduce with just https://www.eclipse.org/downloads/packages/release/2021-06/r/eclipse-ide-enterprise-java-and-web-developers (no extra plugins need to be installed). I just installed this via Eclipse Installer.
Comment 18 Konrad Windszus CLA 2021-06-17 11:29:45 EDT
And I am on Mac OS (11.4) but I don't know if that matters
Comment 19 Jonah Graham CLA 2021-06-17 11:38:06 EDT
Created attachment 286615 [details]
show in terminal appears

I just downloaded that on Windows, removed the automatically discovered git bash, and the show in terminal appears fine for me. 

Another difference I see is that in your case the deprecated Navigator is in the Show In, and I don't see that.
Comment 20 Jonah Graham CLA 2021-06-17 12:22:56 EDT
I don't have access to a Mac, so not sure how to proceed here.
Comment 21 Jonah Graham CLA 2021-06-18 16:05:17 EDT
Created attachment 286631 [details]
macos screenshot showing the expected menu item

(In reply to Jonah Graham from comment #20)
> I don't have access to a Mac, so not sure how to proceed here.

I got hold of one to try a few experiments. With a vanilla JEE 2021-06 I still can't reproduce. I created a new Maven project and a new plain Java project and both worked fine. The screenshot is the Maven project.

I can see some other plug-ins are installed from your screenshot. I wonder if either the other plug-ins are the problem, or if reusing an old workspace causes an issue.