472848 – Figure.findMouseEventTargetInDescendantsAt() returns incorrect result

Bug 472848 - Figure.findMouseEventTargetInDescendantsAt() returns incorrect result

Summary: Figure.findMouseEventTargetInDescendantsAt() returns incorrect result

Status:	RESOLVED FIXED

Alias:	None

Product:	GEF
Classification:	Tools
Component:	GEF-Legacy Draw2d (show other bugs)
Version:	3.10.0
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	3.10.1 (Mars SR1) RC1
Assignee:	Alexander Nyßen
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2015-07-16 11:08 EDT by Mike Marchand
Modified:	2015-07-28 12:38 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Proposal (1.05 KB, text/plain) 2015-07-16 11:12 EDT, Mike Marchand	nyssen: iplog+	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mike Marchand

2015-07-16 11:08:00 EDT

This method will return earlier than it should.

/**
 * Searches this Figure's children for the deepest descendant for which
 * {@link #isMouseEventTarget()} returns <code>true</code> and returns that
 * descendant or <code>null</code> if none found.
 * 
**/

There is a list of children to be searched for a mouse event target.  The bug occurs when there is a child figure that is visible, enabled and also contains the coordinates of the mouse point and in the event that findMouseEventTargetAt(x,y) returns null.  If this happens, the function returns without searching for a mouse event target on the figure's other children.

Comment 1 Mike Marchand

2015-07-16 11:12:42 EDT

Created attachment 255247 [details]
Proposal

Return early only if (fig != null)

Comment 2 Alexander Nyßen

2015-07-27 14:06:12 EDT

Indeed, this seems to be the case. Could you please sign the CLA and confirm that your contribution is provided under the terms of the Certificate of Origin (https://www.eclipse.org/legal/CoO.php?)?

Comment 3 Mike Marchand

2015-07-27 17:14:23 EDT

Thanks Alexander.  My CLA is now been signed.

Comment 4 Alexander Nyßen

2015-07-28 01:58:11 EDT

(In reply to Mike Marchand from comment #3)
> Thanks Alexander.  My CLA is now been signed.

Thanks. I know its annoying, but as the contribution was not provided via Gerrit, in order to sign-off it off, I also need a statement from you that it complies to the CoO.

Comment 5 Mike Marchand

2015-07-28 08:58:17 EDT

This contribution complies with http://www.eclipse.org/legal/CoO.php"

Comment 6 Alexander Nyßen

2015-07-28 12:38:02 EDT

Thanks. I pushed your changes to origin/R3_10_maintenance and origin/master. Resolving as fixed in 3.10.1 RC1.