Bug 472080 - Poor Contrast in Accelerator Text when Menu is highlight
Summary: Poor Contrast in Accelerator Text when Menu is highlight
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P2 normal (vote)
Target Milestone: 10.0   Edit
Assignee: Jefferson Lam CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2015-07-07 12:48 EDT by Steve Northover CLA
Modified: 2015-07-21 14:43 EDT (History)
5 users (show)

See Also:

Attachments
A picture of the problem (8.73 KB, image/png)
2015-07-07 12:48 EDT, Steve Northover CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Northover CLA 2015-07-07 12:48:22 EDT 
Created attachment 255033 [details]
A picture of the problem

1) Run Orion
2) File->Undo ... (NOTE: just highlight the item, don't select it)
3) BUG: The accelerator text Ctrl+Z is dim and hard to read

Likely, the accelerator text color should be the same as the normal menu item text color.
Comment 1 Steve Northover CLA 2015-07-07 12:56:55 EDT 
There are likely other places in Orion where contrast is bad but let's find and fix this one first.
Comment 2 Steve Northover CLA 2015-07-07 12:56:59 EDT 
There are likely other places in Orion where contrast is bad but let's find and fix this one first.
Comment 3 Carolyn MacLeod CLA 2015-07-07 14:12:10 EDT 
In case it's helpful: http://webaim.org/resources/contrastchecker/
Comment 4 Curtis Windatt CLA 2015-07-21 13:13:59 EDT 
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=4d3b9923254236c79a2862fad745aa20f52a0e73
Jefferson suggested this one line fix which I tested and approved.
Comment 5 Jefferson Lam CLA 2015-07-21 14:43:20 EDT 
Fixed this bug by removing this line from theme.css: 

.dropdownMenuItem .dropdownKeyBinding {
-	color: grey !important; /* !important to override .dropdownMenuItem */
...

Fix was pushed by Curtis.