Bug 472033 - WorkspaceImageDescription as Region or RegionContainer style
Summary: WorkspaceImageDescription as Region or RegionContainer style
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 3.0.0   Edit
Hardware: All All
: P1 enhancement (vote)
Target Milestone: 3.1.0   Edit
Assignee: Maxime Porhel CLA
QA Contact:
URL:
Whiteboard: needtest
Keywords: triaged
Depends on:
Blocks: 470859
  Show dependency tree
 
Reported: 2015-07-07 05:16 EDT by Maxime Porhel CLA
Modified: 2015-10-16 09:09 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Porhel CLA 2015-07-07 05:16:50 EDT 
This ticket has been created to centralize the correction to do in compartiment support  to correctly handle the workspace image style set on Region/RegionContainer from the VSM or from the tabbar button.
Comment 1 Maxime Porhel CLA 2015-07-07 05:20:58 EDT 
Do not forget to remove the ContainerMappingChildrenPresentationConstraints.REGION_REGION_CONTAINER_MAPPING_STYLE_RULE_ID constraint once the image support will be completed.
Comment 2 Maxime Porhel CLA 2015-08-24 09:14:30 EDT 
Fist found issue: the Regions are not well located in their RegionContainer when it has a WorkspaceImageDescription: the insets of the content pane seem to be misconfigured.
Comment 3 Eclipse Genie CLA 2015-08-24 10:43:47 EDT 
New Gerrit change created: https://git.eclipse.org/r/54409
Comment 4 Eclipse Genie CLA 2015-08-24 10:43:48 EDT 
New Gerrit change created: https://git.eclipse.org/r/54408
Comment 5 Eclipse Genie CLA 2015-08-24 11:07:29 EDT 
New Gerrit change created: https://git.eclipse.org/r/54416
Comment 6 Maxime Porhel CLA 2015-08-25 05:51:27 EDT 
Additional issues corrected by the current: 
 . the border size/color changes are managed only for the FlatContainerStyleDescription 
    -> https://git.eclipse.org/r/#/c/54408/
 . the image needs improvements when workspacePath is or becomes empty to be consistent with the part creation, in the same code area: the gradient style changes are handled only for the freeform DNodeContainer but not for the DNodeList and Regions
    -> https://git.eclipse.org/r/#/c/54409/
 . the corner refresh needs to be update to handle preceding/following regions which does not necessarily support corners (e.g. WorkspaceImage)
    -> https://git.eclipse.org/r/#/c/54416/
Comment 9 Eclipse Genie CLA 2015-08-26 04:13:43 EDT 
New Gerrit change created: https://git.eclipse.org/r/54565
Comment 10 Eclipse Genie CLA 2015-08-26 05:44:50 EDT 
New Gerrit change created: https://git.eclipse.org/r/54571
Comment 11 Eclipse Genie CLA 2015-08-26 12:04:14 EDT 
New Gerrit change created: https://git.eclipse.org/r/54601
Comment 12 Eclipse Genie CLA 2015-08-27 04:08:40 EDT 
New Gerrit change created: https://git.eclipse.org/r/54660
Comment 18 Maxime Porhel CLA 2015-10-13 09:54:47 EDT 
Validation can be done using the compartment junit data test located in org.eclipse.sirius.tests.junit/data/unit/compartments

Create a project named DesignerTestProject and paste the data in it.


Open ImageDiag (it allows to check the behavior withimage styles defined in the VSM)
Check that image (Regions and RegionContainer) are displayed but also the VSM defined borders.
Check that you can use the tabbar button to change the image and then reset the style. 

Open the VStackDiag (and then the HStackDiag), change the styles of Regions and RegionContainers to an image and then reset the style. 

No error should be thrown (or printed in the console) and each step should produce a consistent diagram and layout.
Comment 19 Florian Barbin CLA 2015-10-15 03:31:13 EDT 
Verified on Sirius 3.1.0.201510140809
Comment 20 Pierre-Charles David CLA 2015-10-16 09:09:12 EDT 
Available in Sirius 3.1.0.