Bug 471104 - Edge with labels and connected ports compound moves
Summary: Edge with labels and connected ports compound moves
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 3.0.0   Edit
Hardware: PC Mac OS X
: P3 enhancement (vote)
Target Milestone: 3.1.0   Edit
Assignee: Florian Barbin CLA
QA Contact: Laurent Redor CLA
URL:
Whiteboard:
Keywords: triaged
Depends on: 471018
Blocks: 500347
  Show dependency tree
 
Reported: 2015-06-26 05:12 EDT by Maxime Porhel CLA
Modified: 2017-06-20 10:40 EDT (History)
2 users (show)

See Also:

Attachments
Exhange and ports sample (69.72 KB, image/jpeg)
2015-06-26 05:12 EDT, Maxime Porhel CLA 		no flags Details
Use Case (23.37 KB, application/zip)
2015-08-27 08:41 EDT, Florian Barbin CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Porhel CLA 2015-06-26 05:12:16 EDT 
Created attachment 254745 [details]
Exhange and ports sample

In specific cases, we can find edges connected to border nodes. For example in Cappela [1] architecture and data flow diagrams, exchanges are connected to port in and port out. When the user wants to move an exchange on a layouted diagram, he has to move the source port, then the target port and possibly move some bendpoints of the edge.

The goal of this evolution is to add the capability to move the group {edge, label, ports} in a single "drag like" operation when the user uses a keyboard modifier and drag/move the edge.

This evolution only deals with the basic and direct cases: 
* the moved group contain 1 edge and two bordered nodes which have only one connection: the moved one.
* the group move is unidirectional and authorized only when there is no conflict on the resulting border node positions.

[1] http://polarsys.org/capella/features.html
Comment 2 Florian Barbin CLA 2015-08-27 08:41:45 EDT 
Created attachment 256179 [details]
Use Case
Comment 5 Florian Barbin CLA 2015-08-28 04:37:42 EDT 
Commits 48392bf398b5305f9833237fce00682aeab2a222 and d1f3210d8708d8350f8813b7d99bed431894cd98 implement the new feature.
The SWTBot tests will be added in a future commit.
Comment 6 Eclipse Genie CLA 2015-08-31 11:22:35 EDT 
WARNING: this patchset contains 3287 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Comment 8 Florian Barbin CLA 2015-09-04 03:42:44 EDT 
SWTBot tests merged
Comment 9 Laurent Redor CLA 2015-09-21 12:44:28 EDT 
By using the use case of the test, /org.eclipse.sirius.tests.swtbot/data/unit/moveEdgeGroup, when I moved edge5 with F3 key pressed, the final result is OK but the feedback of the edge is wrong. In documentation, it seems that the edge feedback is not drawn during the move.
It is OK for oblique edges but not for rectilinear edges.
Comment 10 Eclipse Genie CLA 2015-09-22 04:51:52 EDT 
New Gerrit change created: https://git.eclipse.org/r/56409
Comment 12 Florian Barbin CLA 2015-09-23 09:50:09 EDT 
Fixed. See previous message
Comment 13 Laurent Redor CLA 2015-09-24 10:04:02 EDT 
Verified with Sirius 3.1.0.201509231407
Comment 14 Pierre-Charles David CLA 2015-10-16 09:10:55 EDT 
Available in Sirius 3.1.0.
Comment 15 Eclipse Genie CLA 2017-01-20 08:53:51 EST 
New Gerrit change created: https://git.eclipse.org/r/89209
Comment 18 Eclipse Genie CLA 2017-06-12 03:09:21 EDT 
New Gerrit change created: https://git.eclipse.org/r/99097
Comment 19 Eclipse Genie CLA 2017-06-12 03:09:23 EDT 
New Gerrit change created: https://git.eclipse.org/r/99096
Comment 22 Eclipse Genie CLA 2017-06-19 10:02:57 EDT 
New Gerrit change created: https://git.eclipse.org/r/99589
Comment 23 Eclipse Genie CLA 2017-06-19 10:02:59 EDT 
New Gerrit change created: https://git.eclipse.org/r/99588