Community
Participate
Working Groups
EMF-generated code can support I18N if generated with the proper option, which we haven't done until now. It is not very costly however: * set nonNLSMarkers="true" in the genmodel * re-generate * review all @generated NOT code to make sure it follows the same rules See https://git.eclipse.org/r/#/c/46611 and all the related drafts. It should be an easy first step for I18N (see bug 459993), and it will setup the EMF-specific APIs for I18N, which we probably want to use instead of the Eclipse one.
In our genmodels, we also have documentation strings which are visible at least to specifiers (e.g. expressions documentation). This may be out of scope for now, as I don't think end-users of a Sirius-based modeler can be exposed to them, but when we handle the internationalization of the specification environment itself, we will need to replace these with keys in the genmodel, and modify our runtime to lookup the values in localizable property files.
For some reason, even after generating with nonNLSMarkers="true", many strings which are technical identifiers are left without markers. Among them (there may be others I have not seen yet): * for each EPackage implementation, the eNAME, eNS_URI and eNS_PREFIX. * for each EENum implementation, the name and literal constructor parameters. I believe all of these should be marked NON-NLS manually.
(In reply to Pierre-Charles David from comment #3) > For some reason From the discussion in bug #153725, it's a JMerge bug/limitation. The markers would probably have been correctly generated if we had set the nonNLSMarkers="true" for the first generation, but it fails to add them on already existing files. Anyway, this confirms that marking all of these as NON-NLS is the correct thing to do.
New Gerrit change created: https://git.eclipse.org/r/53299
New Gerrit change created: https://git.eclipse.org/r/53300 WARNING: this patchset contains 20327 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
New Gerrit change created: https://git.eclipse.org/r/53319
New Gerrit change created: https://git.eclipse.org/r/53320
New Gerrit change created: https://git.eclipse.org/r/53713
New Gerrit change created: https://git.eclipse.org/r/53714
Gerrit change https://git.eclipse.org/r/53299 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c36fc817168371a74c342ab04532b43b196720a6
Gerrit change https://git.eclipse.org/r/53714 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=eff0ef605389c1323ffffe5c19dac2928ab76ecc
Gerrit change https://git.eclipse.org/r/53713 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=9f1dabc0c3d7494901fca1210981d612ec0fea59
Gerrit change https://git.eclipse.org/r/53319 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=636f99cec456ad931602c67772be77b9a4f1e82b
Gerrit change https://git.eclipse.org/r/53300 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=386ce9954658168af19272c62801fd95fb0e972b
Fixed.
No validation: Technical issue
Available in Sirius 3.1.0.
