Bug 470691 - [1.8][null] custom nonnullbydefault annotation is not recognized
Summary: [1.8][null] custom nonnullbydefault annotation is not recognized
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.10 M1   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2015-06-22 06:01 EDT by Stephan Herrmann CLA
Modified: 2018-12-04 13:11 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2015-06-22 06:01:49 EDT 
When using custom null annotations in Java 8, a nonnull-by-default annotation is not recognized if it lacks the expected details.

See http://stackoverflow.com/questions/30138400/using-null-analysis-annotations-in-java8
Comment 1 Stephan Herrmann CLA 2016-03-25 10:30:33 EDT 
Too much on my plate for 4.6. Bulk deferral to 4.7
Comment 2 Stephan Herrmann CLA 2017-05-16 12:05:28 EDT 
Ran out of time for 4.7. Bulk move to 4.8.
Comment 3 Manoj N Palat CLA 2018-05-16 12:56:15 EDT 
bulk move out of 4.8
Comment 4 Eclipse Genie CLA 2018-08-30 13:42:29 EDT 
New Gerrit change created: https://git.eclipse.org/r/128385
Comment 5 Stephan Herrmann CLA 2018-08-30 13:45:13 EDT 
(In reply to Eclipse Genie from comment #4)
> New Gerrit change created: https://git.eclipse.org/r/128385

A few tests demonstrating that a custom NonNullByDefault is correctly evaluated, both at 1.7- and 1.8+, annotation existing in source or .class.

Not sure if this got fixed in the interim, or s.t. is different from the original case on SO.
Comment 6 Eclipse Genie CLA 2018-09-04 05:25:00 EDT 
New Gerrit change created: https://git.eclipse.org/r/128627
Comment 7 Eclipse Genie CLA 2018-09-04 11:25:28 EDT 
Gerrit change https://git.eclipse.org/r/128627 was merged to [R4_9_maintenance].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=2364896e02183459f87298143965a5162597ab58
Comment 8 Stephan Herrmann CLA 2018-09-04 11:28:04 EDT 
(In reply to Eclipse Genie from comment #7)
> Gerrit change https://git.eclipse.org/r/128627 was merged to
> [R4_9_maintenance].
> Commit:
> http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/
> ?id=2364896e02183459f87298143965a5162597ab58

I pushed the new tests for 4.9RC2, but not yet to master, which hasn't been declared open for 4.10, yet.

=> Bug stays open as a reminder.
Comment 9 Manoj N Palat CLA 2018-09-11 09:23:47 EDT 
(In reply to Stephan Herrmann from comment #8)
> (In reply to Eclipse Genie from comment #7)
> > Gerrit change https://git.eclipse.org/r/128627 was merged to
> > [R4_9_maintenance].
> > Commit:
> > http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/
> > ?id=2364896e02183459f87298143965a5162597ab58
> 
> I pushed the new tests for 4.9RC2, but not yet to master, which hasn't been
> declared open for 4.10, yet.
> 
> => Bug stays open as a reminder.

@Stephan: I am targeting this to 4.10 so that it shows up in the queries.
Comment 10 Stephan Herrmann CLA 2018-12-04 13:11:06 EST 
(In reply to Stephan Herrmann from comment #8)
> (In reply to Eclipse Genie from comment #7)
> > Gerrit change https://git.eclipse.org/r/128627 was merged to
> > [R4_9_maintenance].
> > Commit:
> > http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/
> > ?id=2364896e02183459f87298143965a5162597ab58
> 
> I pushed the new tests for 4.9RC2, but not yet to master, which hasn't been
> declared open for 4.10, yet.
> 
> => Bug stays open as a reminder.

At a closer look, no cherry-pick was needed, but the tests have long been merged to master via https://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=d9aa55c09e90009aa1631ccd7837f974acebb266