Bug 469180 - Remove specific mention of "Delta Pack"
Summary: Remove specific mention of "Delta Pack"
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.5 RC4   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-02 12:48 EDT by David Williams CLA
Modified: 2015-06-02 16:26 EDT (History)
4 users (show)

See Also:
Lars.Vogel: review+
daniel_megert: review+


Attachments
proposed patch, to remove the paragraph that mentions Delta Pack (1.07 KB, patch)
2015-06-02 12:51 EDT, David Williams CLA
no flags Details | Diff
new patch to still remove "Delta Pack" (1.23 KB, patch)
2015-06-02 15:17 EDT, David Williams CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2015-06-02 12:48:53 EDT
In support of bug 468690 and bug 419246 we should remove specific mention of the "Delta Pack" from PDE UI. 

The only reference I could find to it was in 
/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties

Not sure if that is a "help" file? Or ... literally part of the UI? 
Oh .. product editor, I bet? 

That file current has ... 

Product_overview_exporting = <form>\
<p>Use the <a href="action.export">Eclipse Product export wizard</a> to package and export the product defined in this configuration.</p><p></p>\
<p>To export the product to multiple platforms:</p>\
<li style="text" value="1." bindent="5">Install the RCP delta pack in the target platform.</li>\
<li style="text" value="2." bindent="5">List all the required fragments on the <a href="configuration">Dependencies</a> page.</li>\
</form>

My recommendation is just to remove all reference to it ... and not try to 
give advice on "how to export multiple platforms". 

Product_overview_exporting = <form>\
<p>Use the <a href="action.export">Eclipse Product export wizard</a> to package and export the product defined in this configuration.</p>\
</form>

While we do plat to update a wiki page on "how to" accomplish the same thing, I am not sure it is "supported enough" that we should make it part of the UI.
Comment 1 David Williams CLA 2015-06-02 12:51:23 EDT
Created attachment 254029 [details]
proposed patch, to remove the paragraph that mentions Delta Pack
Comment 2 David Williams CLA 2015-06-02 12:53:36 EDT
I propose we put this in for RC4. (though, I'm not a PDE Committer, so not sure I can officially propose it).
Comment 3 Lars Vogel CLA 2015-06-02 13:52:14 EDT
(In reply to David Williams from comment #1)
> Created attachment 254029 [details]
> proposed patch, to remove the paragraph that mentions Delta Pack

A Gerrit review would be easier to merge. 

> I propose we put this in for RC4.

+1 by me as a component lead, Curtis or Dani should make the final decision IMHO.
Comment 4 Curtis Windatt CLA 2015-06-02 14:21:32 EDT
This does make the export to multiple platforms feature undiscoverable.  If the 'delta pack' won't be available going forward, then yes +1 to remove the comments.  However, we will need an open bug to add in new steps to export to multiple platforms.  We could probably go a step further and in the export wizard provide more detailed steps on setting up the platform launcher fragments.

Also, Lars or Vikas will have to look at the help doc (specifically for the export wizard) and see what mentions there are for the delta pack.
Comment 5 Dani Megert CLA 2015-06-02 15:10:59 EDT
(In reply to Curtis Windatt from comment #4)
> This does make the export to multiple platforms feature undiscoverable.  If
> the 'delta pack' won't be available going forward, then yes +1 to remove the
> comments.

Yes, that's the future.


>  However, we will need an open bug to add in new steps to export
> to multiple platforms. 

Bug 469178: Update "delta pack" wiki for Mars release


David is about to upload a new patch the links to that wiki.
Comment 6 David Williams CLA 2015-06-02 15:17:57 EDT
Created attachment 254034 [details]
new patch to still remove "Delta Pack"

This patch still mentions "multiple platforms", 
but points people to the wiki page section at 
https://wiki.eclipse.org/Building#Cross-platform_build

(The actual content needed there, has yet to be written, as Dani mentioned, being tracked in Bug 469178).
Comment 7 Dani Megert CLA 2015-06-02 16:25:41 EDT
(In reply to David Williams from comment #6)
> Created attachment 254034 [details] [diff]
> new patch to still remove "Delta Pack"
> 
> This patch still mentions "multiple platforms", 
> but points people to the wiki page section at 
> https://wiki.eclipse.org/Building#Cross-platform_build
> 
> (The actual content needed there, has yet to be written, as Dani mentioned,
> being tracked in Bug 469178).

Thanks David. The code handles the hrefs hence one must also adjust the code and implement the opening of the URL. I've done that, added the missing dot, and then submitted your patch with http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=