Bug 468679 - Wizard banner image should be transparent to support dark theme
Summary: Wizard banner image should be transparent to support dark theme
Status: RESOLVED FIXED
Alias: None
Product: Oomph
Classification: Tools
Component: Setup (show other bugs)
Version: 1.1.0   Edit
Hardware: PC Mac OS X
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Eike Stepper CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2015-05-28 12:10 EDT by Andreas Sewe CLA
Modified: 2015-06-10 05:14 EDT (History)
1 user (show)

See Also:


Attachments
Wizard banner in preference recorder (OS X 10.10.3, Eclipse Mars RC2, dark theme) (126.68 KB, image/png)
2015-05-28 12:10 EDT, Andreas Sewe CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sewe CLA 2015-05-28 12:10:11 EDT
Created attachment 253907 [details]
Wizard banner in preference recorder (OS X 10.10.3, Eclipse Mars RC2, dark theme)

See the attached screenshot (made under Mars RC2).

FYI, some wizards (File > New > Project...) already use a transparent background that works well in both themes.
Comment 1 Eike Stepper CLA 2015-05-29 00:23:24 EDT
Can you please attach a transparent *background* banner image? The one with the gradient...
Comment 2 Andreas Sewe CLA 2015-05-29 02:45:00 EDT
(In reply to Eike Stepper from comment #1)
> Can you please attach a transparent *background* banner image? The one with
> the gradient...

Not sure I understand. Do you mean an example of where this works already? I think the wizard banner of File > New > Project... qualifies, but you probably meant something else.
Comment 3 Eike Stepper CLA 2015-05-29 02:53:27 EDT
No, these banner images are always composed of a gradient background image and the  dialog-specific image (Oomph in our case). I need the gradient background image as tansparent png so that I can overlay our Oomph image on top of it.
Comment 4 Andreas Sewe CLA 2015-05-29 03:18:10 EDT
(In reply to Eike Stepper from comment #3)
> No, these banner images are always composed of a gradient background image
> and the  dialog-specific image (Oomph in our case). I need the gradient
> background image as tansparent png so that I can overlay our Oomph image on
> top of it.

Ah, got it.

I unfortunately don't know where the platform team keeps their reference images. It's not in [1] (nothing is yet, see Bug 422139), but [2] look promising.

[1] <https://git.eclipse.org/c/platform/eclipse.images.git/>
[2] <https://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org.eclipse.ui.images>
Comment 5 Eike Stepper CLA 2015-05-29 03:38:54 EDT
This one should be it: https://git.eclipse.org/c/platform/eclipse.platform.ui.git/plain/bundles/org.eclipse.ui.images/eclipse-png/org.eclipse.jface/icons/full/title_banner.png

But it's not making use of its transparency ;-(

I'm willing to redesign all our banner images for you, but I don't have the time to figure out where this transparent background image is. Please find it and attach it here.
Comment 6 Andreas Sewe CLA 2015-05-29 04:11:58 EDT
(In reply to Eike Stepper from comment #5)
> This one should be it:
> https://git.eclipse.org/c/platform/eclipse.platform.ui.git/plain/bundles/org.
> eclipse.ui.images/eclipse-png/org.eclipse.jface/icons/full/title_banner.png
> 
> But it's not making use of its transparency ;-(
> 
> I'm willing to redesign all our banner images for you, but I don't have the
> time to figure out where this transparent background image is. Please find
> it and attach it here.

No hurry. I just filed this bug yesterday as it came up testing RC2, not because I consider it critical. Oomph certainly doesn't look worse than other parts of Eclipse using the dark theme. ;-)

But I'll continue looking for the transparent background image. If I find it, I'll tell you.
Comment 7 Eike Stepper CLA 2015-06-02 02:22:32 EDT
I've redesigned most of the banner images to be transparent:
http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/commit/?id=0adc944314e8b1f68ac8bd36f0cbcd06efd6ff8d

For the Oomph logo banner I'm still waiting for an SVG file from our graphics designer...
Comment 8 Eike Stepper CLA 2015-06-10 05:14:00 EDT
I've made the last remaining banner image transparent:
http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/commit/?id=4264f010289bd539fca59f8b044bf07886b0ad3a