Bug 468554 - [Dark theme] Commit dialog is not fully adjusted to dark theme
Summary: [Dark theme] Commit dialog is not fully adjusted to dark theme
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 4.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2015-05-27 17:42 EDT by Michal Niewrzal CLA
Modified: 2018-08-02 03:56 EDT (History)
2 users (show)

See Also:

Attachments
screenshot (36.72 KB, image/png)
2015-05-27 17:42 EDT, Michal Niewrzal CLA 		no flags Details
Eclipse 4.6 (Neon) (42.62 KB, image/png)
2016-08-30 08:45 EDT, Michal Niewrzal CLA 		no flags Details
Commit Dialog in 2018-09 on macOS (55.26 KB, image/png)
2018-08-02 02:44 EDT, Matthias Becker CLA 		no flags Details
Commit Dialog in 2018-09 on Ubuntu (77.95 KB, image/png)
2018-08-02 03:08 EDT, Michal Niewrzal CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Niewrzal CLA 2015-05-27 17:42:45 EDT 
Created attachment 253873 [details]
screenshot

Commit dialog is not fully adjusted to dark theme. See screenshot.

Ubuntu 15.04 (Unity)
4.5.0RC1
Build id: 20150521-1252
Comment 1 Lars Vogel CLA 2016-08-30 08:37:56 EDT 
Is this still the case in Eclipse 4.6 (Neon)?
Comment 2 Michal Niewrzal CLA 2016-08-30 08:45:17 EDT 
Created attachment 263846 [details]
Eclipse 4.6 (Neon)

Looks better but main text area is still white.

Fedora 24, GTK3
Comment 3 Matthias Becker CLA 2018-08-02 02:41:39 EDT 
How do I open that dialog? I always use the git staging view.
Comment 4 Matthias Becker CLA 2018-08-02 02:44:21 EDT 
Created attachment 275224 [details]
Commit Dialog in 2018-09 on macOS

the dialog looks good on macOS. Does this still appear on your OS?
Comment 5 Michal Niewrzal CLA 2018-08-02 03:08:35 EDT 
Created attachment 275226 [details]
Commit Dialog in 2018-09 on Ubuntu

I have no access to Fedora now but it looks ok on Ubuntu 16.04
Comment 6 Matthias Becker CLA 2018-08-02 03:38:03 EDT 
(In reply to Michal Niewrzal from comment #5)
> Created attachment 275226 [details]
> Commit Dialog in 2018-09 on Ubuntu
> 
> I have no access to Fedora now but it looks ok on Ubuntu 16.04

So can we close this?
Comment 7 Michal Niewrzal CLA 2018-08-02 03:40:01 EDT 
I believe so :)