Bug 468243 - [Model Explorer] New Relationship target selection dialog problems
Summary: [Model Explorer] New Relationship target selection dialog problems
Status: NEW
Alias: None
Product: Papyrus
Classification: Modeling
Component: Views (show other bugs)
Version: 1.1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-25 20:07 EDT by Christian Damus CLA
Modified: 2017-09-08 09:50 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Damus CLA 2015-05-25 20:07:30 EDT
Papyrus Mars RC1

The "New Relationship" menu actions in the Model Explorer context menu show dialogs for selection of the target element.  There are two distinct problems with these dialogs:

* unlike the selection dialogs in the reference property editors in the Properties
  view, there is no filter field to help scale the browsing of large models
* many relationships (dependencies especially) support multiple "targets", but
  the dialog allows only a single selection for these
* many relationships (dependencies especially) support multiple "sources", but
  the menu actions only take one of the selected elements as the source (I might
  have expected them to be disabled for multiple selections if they weren't
  going to operate on all selected elements)
Comment 1 Patrik Nandorf CLA 2015-06-10 03:36:07 EDT
(In reply to Christian W. Damus from comment #0)
> Papyrus Mars RC1
> 
> The "New Relationship" menu actions in the Model Explorer context menu show
> dialogs for selection of the target element.  There are two distinct
> problems with these dialogs:
> 
> * unlike the selection dialogs in the reference property editors in the
> Properties
>   view, there is no filter field to help scale the browsing of large models

Agree, filtering is needed (as well as sorting alphabetically), work is ongoing

> * many relationships (dependencies especially) support multiple "targets",
> but
>   the dialog allows only a single selection for these
> * many relationships (dependencies especially) support multiple "sources",
> but
>   the menu actions only take one of the selected elements as the source (I
> might
>   have expected them to be disabled for multiple selections if they weren't
>   going to operate on all selected elements)

Regarding multiple sources/targets, there are shortcomings in the ElementType framework only allowing requests to have one source and one target. Until this is fixed, multiple selection will be disabled. The fix for this is planned for Mars SR1.
Comment 2 Christian Damus CLA 2015-06-10 06:28:08 EDT
(In reply to Patrik Nandorf from comment #1)
>
> Regarding multiple sources/targets, there are shortcomings in the
> ElementType framework only allowing requests to have one source and one
> target. Until this is fixed, multiple selection will be disabled. The fix
> for this is planned for Mars SR1.

Or just compose multiple command to add multiple sources/targets to a relationship.

I would expect a change in GMF to require new API, which might rather wait for Neon?
Comment 3 Eclipse Genie CLA 2016-02-29 03:14:20 EST
New Gerrit change created: https://git.eclipse.org/r/67513
Comment 4 Eclipse Genie CLA 2016-02-29 09:00:34 EST
New Gerrit change created: https://git.eclipse.org/r/67543