Bug 46788 - Export scripts: shouldn't use variable name version
Summary: Export scripts: shouldn't use variable name version
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M5   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-17 13:04 EST by Dirk Baeumer CLA
Modified: 2003-11-21 13:49 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Baeumer CLA 2003-11-17 13:04:42 EST 
N20031114

Using the variable name version causes grief when exporting multiple plug_ins. 
A variable in Ant can only be set once. Every plugin should use its own 
version variable like jdt_core_version.
Comment 1 Olivier Thomann CLA 2003-11-20 10:31:38 EST 
What are you talking about? Would you have steps to what the problem is?
Thanks.
Comment 2 Olivier Thomann CLA 2003-11-21 09:55:32 EST 
I will need more information to understand what you expect.
Comment 3 Dirk Baeumer CLA 2003-11-21 10:06:19 EST 
The plugin export ant srcipt (named exportplugin.xml) under the scripts folder 
of the jdt core project uses the variable name version. Due to limitations for 
Ant (don't ask me why ;-)) values can only be assigned once to variable names. 
When exporting all ZRH plug-ins we export JDT/Core as well. When someone set 
the version variable to some value then this value is used for all exports. 

JDT/UI decided to use specific variable name (e.g.jdt_ui_version) to avoid 
this problem.
Comment 4 Olivier Thomann CLA 2003-11-21 10:14:58 EST 
You mean that you want us to change the code like this:
		<param name="version" value="3.0.0"/>
to
		<param name="jdt_core_version" value="3.0.0"/>

in the exportplugin.xml file?
Comment 5 Olivier Thomann CLA 2003-11-21 10:19:31 EST 
If this is it, this is a trivial change. I released this change.
Comment 6 Olivier Thomann CLA 2003-11-21 10:24:09 EST 
This change doesn't affect the build. It only affects the exportplugin.xml file.
Comment 7 Olivier Thomann CLA 2003-11-21 13:49:32 EST 
Verified in 200311211210.
This is included in jdt/core from CVS version v_387.