Bug 467836 - [BIDI] Remove the call to isProcessingNeeded
Summary: [BIDI] Remove the call to isProcessingNeeded
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Components (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: Neon M5   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 466345
  Show dependency tree
 
Reported: 2015-05-21 07:08 EDT by Moshe WAJNBERG CLA
Modified: 2016-01-19 10:11 EST (History)
3 users (show)

See Also:

Attachments
Removing the call to isProcessingNeeded (2.03 KB, patch)
2015-05-21 07:13 EDT, Moshe WAJNBERG CLA 		no flags Details | Diff
Removing the call to isProcessingNeeded (2.20 KB, patch)
2015-05-21 07:16 EDT, Moshe WAJNBERG CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Moshe WAJNBERG CLA 2015-05-21 07:08:00 EDT 
Now that we have a special preference for Bidi support in the Preferences page (Preferences->General->Globalization see bug 424723) we can safely remove the call to isProcessingNeeded in the StructuredTextProcessor class.
Comment 1 Moshe WAJNBERG CLA 2015-05-21 07:13:54 EDT 
Created attachment 253624 [details]
Removing the call to isProcessingNeeded

Hello Markus,

Could you please review this patch

Thank you
Comment 2 Moshe WAJNBERG CLA 2015-05-21 07:16:36 EDT 
Created attachment 253625 [details]
Removing the call to isProcessingNeeded
Comment 3 Tomer Mahlin CLA 2016-01-06 09:03:17 EST 
@markus, any review comments ?
Comment 4 Markus Keller CLA 2016-01-19 10:11:53 EST 
This is a behavior change that needs to be documented and that needs a test fix.

I've:
- replaced "on bidi locales" in APIs with "in bidi environments"
- removed the calls in the code (rather than commenting them out)
- fixed the failing test

And since there was not any user left, I've:
- deprecated StructuredTextEnvironment#isProcessingNeeded() and explained the alternatives

Fixed with http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=8f964682cfc9a55668029b90994fe4345cd91537

Updated bundle versions with http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=652bb5b7845d77af8ef390d99d4c974f1ec8db3e

Updated porting guide with http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=7c4a6c116938e13e2f4126fdf9471ad0fa872b66