Bug 467734 - plant_at_address_expression() may reference uninitialized structure
Summary: plant_at_address_expression() may reference uninitialized structure
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: 1.3   Edit
Hardware: All Linux
: P3 blocker (vote)
Target Milestone: 1.3   Edit
Assignee: Project Inbox CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-20 12:10 EDT by Jean-Michel Pedrono CLA
Modified: 2015-06-16 03:21 EDT (History)
1 user (show)

See Also:

Attachments
Patch: Bug 467734 - plant_at_address_expression() may reference uninitialized structure (1.14 KB, patch)
2015-05-20 12:12 EDT, Jean-Michel Pedrono CLA 		eugene: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Michel Pedrono CLA 2015-05-20 12:10:44 EDT 
plant_at_address_expression() declares a Value structure (v) without initializing it.
The code then test (v.sym != NULL) without checking <error> value.

Value structure should be clearer before being used, and <error> should be tested before accessing v.sym.
Comment 1 Jean-Michel Pedrono CLA 2015-05-20 12:12:39 EDT 
Created attachment 253602 [details]
Patch: Bug 467734 - plant_at_address_expression() may reference  uninitialized structure

Here is a fix proposal.
Comment 2 Eugene Tarassov CLA 2015-05-20 16:00:44 EDT 
Eclipse does not allow contributing patches without CLA.
Please, sign CLA at http://wiki.eclipse.org/CLA
Comment 3 Jean-Michel Pedrono CLA 2015-05-22 03:03:36 EDT 
CLA signed.
Thanks.
Comment 4 Eugene Tarassov CLA 2015-05-22 13:55:42 EDT 
Committed.
Thanks!